fix: authentication tests on WSL#2706
Merged
mdelapenya merged 2 commits intotestcontainers:mainfrom Aug 19, 2024
stevenh:fix/auth-tests-wsl
Merged
fix: authentication tests on WSL#2706mdelapenya merged 2 commits intotestcontainers:mainfrom stevenh:fix/auth-tests-wsl
mdelapenya merged 2 commits intotestcontainers:mainfrom
stevenh:fix/auth-tests-wsl
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Member
|
I think this is a duplicate of #2705, isn't it? |
Contributor
Author
Same issue different location, happy to merge the two if you want. |
Fix docker auth tests to run on WSL by using the local IP instead of localhost, which can be unreliable. While there refactor the tests to use a helper instead of hand coding each environment setup. Remove duplicate logging about terminating container as default hooks already provide this.
mdelapenya
approved these changes
Aug 19, 2024
Member
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
LGTM, in a follow up, let's reuse what #2705 added for the localhost IP.
Thanks!
mdelapenya
added a commit
that referenced
this pull request
Aug 22, 2024
* main: chore(deps): bump github/codeql-action from 3.24.9 to 3.25.15 (#2677) fix: use of log.Fatal in main (#2739) chore: prepare for next minor development cycle (0.34.0) chore: use new version (v0.33.0) in modules and examples fix: authentication tests on WSL (#2706) fix(registry): compatibility with WSL (#2705)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix docker auth tests to run on WSL by using the local IP instead of localhost, which can be unreliable.
While there refactor the tests to use a helper instead of hand coding each environment setup.
Remove duplicate logging about terminating container as default hooks already provide this.