fix(registry): compatibility with WSL#2705
Merged
mdelapenya merged 4 commits intotestcontainers:mainfrom Aug 19, 2024
stevenh:fix/registry-wsl
Merged
fix(registry): compatibility with WSL#2705mdelapenya merged 4 commits intotestcontainers:mainfrom stevenh:fix/registry-wsl
mdelapenya merged 4 commits intotestcontainers:mainfrom
stevenh:fix/registry-wsl
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdelapenya
reviewed
Aug 9, 2024
mdelapenya
reviewed
Aug 14, 2024
Member
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
Added some comments, this is almost ready to be merged, although I'd like to discuss more with the team about the credentialStore being pinned to "desktop".
In any case, thanks in advance for this fix!
Contributor
Author
|
Depends on #2727 |
Use local IP instead of localhost to access registry container to address failures under WSL where the docker daemon can't access localhost. Refactor tests to use helpers and require reducing code and simplifying the flow. Add a default image which can be used be consumers. Add HostAddress which returns host : port compatible with WSL. Add SetDockerAuthConfig and DockerAuthConfig methods that can be used to easily configure authentication via DOCKER_AUTH_CONFIG environment variable. Fix container clean up which was missed in a number of case.
mdelapenya
reviewed
Aug 16, 2024
mdelapenya
reviewed
Aug 16, 2024
stevenh
commented
Aug 16, 2024
Contributor
Author
stevenh
left a comment
stevenh
left a comment
There was a problem hiding this comment.
Needs a few tweaks
stevenh
commented
Aug 19, 2024
Co-authored-by: Steven Hartland <[email protected]>
mdelapenya
added a commit
that referenced
this pull request
Aug 22, 2024
* main: chore(deps): bump github/codeql-action from 3.24.9 to 3.25.15 (#2677) fix: use of log.Fatal in main (#2739) chore: prepare for next minor development cycle (0.34.0) chore: use new version (v0.33.0) in modules and examples fix: authentication tests on WSL (#2706) fix(registry): compatibility with WSL (#2705)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use local IP instead of localhost to access registry container to address failures under WSL where the docker daemon can't access localhost.
Refactor tests to use helpers and require reducing code and simplifying the flow.
Add a default image which can be used be consumers.
Add HostAddress which returns host : port compatible with WSL.
Add SetDockerAuthConfig and DockerAuthConfig methods that can be used to easily configure authentication via DOCKER_AUTH_CONFIG environment variable.
Fix container clean up which was missed in a number of cases.