fix(redpanda): race condition on port check#2692
Merged
mdelapenya merged 1 commit intotestcontainers:mainfrom Aug 16, 2024
stevenh:fix/redpanda-port-check
Merged
fix(redpanda): race condition on port check#2692mdelapenya merged 1 commit intotestcontainers:mainfrom stevenh:fix/redpanda-port-check
mdelapenya merged 1 commit intotestcontainers:mainfrom
stevenh:fix/redpanda-port-check
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdelapenya
reviewed
Aug 7, 2024
mdelapenya
reviewed
Aug 9, 2024
Use SkipInternalCheck to wait for ports to be bound externally only before trying to get the mapped port. This fixes a race condition in the setup of the container which was causing random test failures.
mdelapenya
approved these changes
Aug 16, 2024
Member
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
LGTM, thanks!
@weeco I'm going to merge this as is, to make progress, although I'd like to get your feedback if possible, as a redpanda contributor, in an eventual issue if you find any concern with this PR: in the end, it only adds stronger wait conditions to mark the container as ready, so I think it's safe to merge.
Thanks in advance
Contributor
|
That looks fine to me, thanks for the fix |
mdelapenya
added a commit
that referenced
this pull request
Aug 16, 2024
* main: fix: config via environment (#2725) fix(redpanda): race condition on port check (#2692) fix: logging restart (#2697) fix!: docker authentication setup (#2727) chore: improve error wrapping (#2720) chore: run make tests in verbose mode (#2734) chore(deps): bump github.com/docker/docker from 27.1.0+incompatible to 27.1.1+incompatible (#2733) fix(kafka): port race on start (#2696) docs: fix broken doc tags (#2732) fix: nginx request failures (#2723) fix(compose): container locking (#2722) fix(wait): log test timeout (#2716) chore: increase timeout values (#2719) chore: remove unused parameters (#2721) chore(mockserver): silence warning about internal port (#2730) feat(wait): skip internal host port check (#2691)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use SkipInternalCheck to wait for ports to be bound externally only before trying to get the mapped port. This fixes a race condition in the setup of the container which was causing random test failures.