Skip to content

test: fix image label test#2689

Merged
mdelapenya merged 1 commit intotestcontainers:mainfrom
stevenh:test/image-label
Aug 7, 2024
Merged

test: fix image label test#2689
mdelapenya merged 1 commit intotestcontainers:mainfrom
stevenh:test/image-label

Conversation

@stevenh
Copy link
Copy Markdown
Contributor

@stevenh stevenh commented Aug 6, 2024

Fix test for image label setting which could fail if the volume already existed.

@stevenh
test: fix image label test
708d410 
Fix test for image label setting which could fail if the volume already
existed.
@stevenh stevenh requested a review from a team as a code owner August 6, 2024 20:20
@netlify
Copy link
Copy Markdown

netlify bot commented Aug 6, 2024 •
edited
Loading

✅ Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 708d410
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/66b28593d9d1b6000833cbd7
😎 Deploy Preview https://deploy-preview-2689--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stevenh stevenh mentioned this pull request Aug 6, 2024
Closed
@mdelapenya mdelapenya self-assigned this Aug 7, 2024
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Aug 7, 2024
mdelapenya
mdelapenya approved these changes Aug 7, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdelapenya mdelapenya merged commit ab3a0f5 into testcontainers:main Aug 7, 2024
@stevenh stevenh deleted the test/image-label branch August 7, 2024 11:32
mdelapenya added a commit that referenced this pull request Aug 7, 2024
@mdelapenya
Merge branch 'main' into v1
36fff00 
* main:
  fix: missing image build errors (#2651)
  test: fix image label test (#2689)
  chore(deps): bump github.com/docker/docker from 27.0.3+incompatible to 27.1.0+incompatible (#2682)
  chore: print Docker Info labels in banner (#2681)
  fix: incorrect parsing of exposedPorts in readiness check (#2658)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdelapenya mdelapenya mdelapenya approved these changes

Assignees

@mdelapenya mdelapenya

Labels

chore Changes that do not impact the existing functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stevenh @mdelapenya