fix: missing image build errors#2651
Merged
mdelapenya merged 1 commit intotestcontainers:mainfrom Aug 7, 2024
stevenh:fix/missing-build-errors
Merged
fix: missing image build errors#2651mdelapenya merged 1 commit intotestcontainers:mainfrom stevenh:fix/missing-build-errors
mdelapenya merged 1 commit intotestcontainers:mainfrom
stevenh:fix/missing-build-errors
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Author
|
Failures look unrelated. |
Member
|
Hey @stevenh this code LGTM. I'd like to merge it but first ask if you see it possible add a test demonstrating the new behaviour. Wdyt? |
Contributor
Author
Good call, I'll work on that. |
Ensure build errors are returned to the caller when PrintBuildLog is not set to true. DisplayJSONMessagesStream and JSONMessage.Display performs processing of the stream to catch command failures, so needs to always be called.
Contributor
Author
|
Ready to go @mdelapenya failure is the flakey test issue |
Contributor
Author
|
Actually scratch that, something strange is going on. I think I might be seeing false passes. |
Contributor
Author
|
Failures we're unrelated |
mdelapenya
approved these changes
Aug 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure build errors are returned to the caller when PrintBuildLog is not set to true.
DisplayJSONMessagesStream and JSONMessage.Display performs processing of the stream to catch command failures, so needs to always be called.