Fix: Couchbase containers intermittently hang on startup#2650
Merged
mdelapenya merged 3 commits intotestcontainers:mainfrom Jul 17, 2024
Merged
Fix: Couchbase containers intermittently hang on startup#2650mdelapenya merged 3 commits intotestcontainers:mainfrom
mdelapenya merged 3 commits intotestcontainers:mainfrom
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
couchbaseEd
force-pushed
the
fix/createPrimaryIndex
branch
from
838510f to
a0c8e35
Compare
Member
|
@couchbaseEd I see a different changeset after the last push-force. Could it be possible that it's incorrect? |
Contributor
Author
|
ah I merged main and then squashed my commits. Just needed to update the branch |
mdelapenya
approved these changes
Jul 17, 2024
Member
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Will merge when the CI passes
mdelapenya
added a commit
that referenced
this pull request
Aug 5, 2024
* main: feat: add grafana-lgtm module (#2660) Added valkey module (#2639) fix: container.Endpoint and wait.FortHTTP to use lowest internal port (#2641) chore: test cleanups (#2657) docs: fix compilation of examples (#2656) feat: add custom container registry substitutor (#2647) fix: couchbase containers intermittently hang on startup (#2650) chore(deps): bump Ryuk to 0.8.1 (#2648) fix: retry on label error (#2644) perf: optimise docker authentication config lookup (#2646)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Checks the http response when creating the a primary index and retries if there is an error.
Why is it important?
When making the call to create the primary index the response isn't checked. This means that any errors returned in the response body are not caught and hence the isPrimaryIndexOnline polls until the timeout. In our case this occurs if we try to create the index to early before the bucket is ready.
Related issues
Run test script posted in original issue to try to reproduce. This is a timing issue so difficult to reproduce consistently.