fix: retry on label error#2644
Merged
mdelapenya merged 1 commit intotestcontainers:mainfrom Jul 16, 2024
stevenh:fix/lable-error-retry
Merged
fix: retry on label error#2644mdelapenya merged 1 commit intotestcontainers:mainfrom stevenh:fix/lable-error-retry
mdelapenya merged 1 commit intotestcontainers:mainfrom
stevenh:fix/lable-error-retry
Conversation
Add system errors to list of permanent errors which fixes infinite retries when a build is attempted with an invalid label.
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Member
|
I guess you mean an invalid label when building the image, right? If so, what would be the impact of merging this and #2637? |
Contributor
Author
Yes I mistakenly had a colon in value of the This was a persistent error, and sent the retry into an infinite loop. #2637 is separate, no conflict there that I can see. |
mdelapenya
added a commit
that referenced
this pull request
Aug 5, 2024
* main: feat: add grafana-lgtm module (#2660) Added valkey module (#2639) fix: container.Endpoint and wait.FortHTTP to use lowest internal port (#2641) chore: test cleanups (#2657) docs: fix compilation of examples (#2656) feat: add custom container registry substitutor (#2647) fix: couchbase containers intermittently hang on startup (#2650) chore(deps): bump Ryuk to 0.8.1 (#2648) fix: retry on label error (#2644) perf: optimise docker authentication config lookup (#2646)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add system errors to list of permanent errors which fixes infinite retries when a build is attempted with an invalid label.