fix: container.Endpoint and wait.FortHTTP to use lowest internal port#2641
Merged
mdelapenya merged 1 commit intotestcontainers:mainfrom Jul 18, 2024
stevenh:fix/endpoint
Merged
fix: container.Endpoint and wait.FortHTTP to use lowest internal port#2641mdelapenya merged 1 commit intotestcontainers:mainfrom stevenh:fix/endpoint
mdelapenya merged 1 commit intotestcontainers:mainfrom
stevenh:fix/endpoint
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
stevenh
changed the title
Member
|
Hi @stevenh do you think we should mark this as a breaking change, as we are changing the docs from Other than that, LGTM |
Contributor
Author
I don't think so as I believe that original intent of |
Member
|
Wdyt if we change the title to |
stevenh
changed the title
stevenh
changed the title
Contributor
Author
Updated the title to something similar, which I hope is a little bit more concise, let me know what you think? |
mdelapenya
reviewed
Jul 17, 2024
Ensure Container.Endpoint returns the lowest numbered aka first port there is more than one exposed. Ensure that wait.ForHTTP uses the lowest numbered aka first port when there is more than one exposed. Prior to this a random port would be returned leading to unpredictable results. Clarify which port is uses by using lowest vs first, which could otherwise be interpreted as the first one specified. Fixed: #2640
mdelapenya
added a commit
that referenced
this pull request
Aug 5, 2024
* main: feat: add grafana-lgtm module (#2660) Added valkey module (#2639) fix: container.Endpoint and wait.FortHTTP to use lowest internal port (#2641) chore: test cleanups (#2657) docs: fix compilation of examples (#2656) feat: add custom container registry substitutor (#2647) fix: couchbase containers intermittently hang on startup (#2650) chore(deps): bump Ryuk to 0.8.1 (#2648) fix: retry on label error (#2644) perf: optimise docker authentication config lookup (#2646)
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Aug 6, 2024
* main: chore: print Docker Info labels in banner (testcontainers#2681) fix: incorrect parsing of exposedPorts in readiness check (testcontainers#2658) feat: add grafana-lgtm module (testcontainers#2660) Added valkey module (testcontainers#2639) fix: container.Endpoint and wait.FortHTTP to use lowest internal port (testcontainers#2641)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure
Container.Endpointreturns the lowest numbered aka first port when there is more than one exposed.Ensure that
wait.ForHTTPuses the lowest numbered aka first port when there is more than one exposed.Prior to this a random port would be returned leading to unpredictable
results.
Fixed: #2640