feat(MustConn): Add MustConnectionString on (some) dbs#2343
Merged
mdelapenya merged 4 commits intotestcontainers:mainfrom Mar 18, 2024
Merged
feat(MustConn): Add MustConnectionString on (some) dbs#2343mdelapenya merged 4 commits intotestcontainers:mainfrom
mdelapenya merged 4 commits intotestcontainers:mainfrom
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdelapenya
reviewed
Mar 12, 2024
Member
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
One point about the unit tests, I could not figure out a way to get a panic out of the ConnectionString methods.
It's fine, I would not worry to get 100% coverage meanwhile it's clear, which this PR is.
Other than that, LGTM, thank you!
mdelapenya
approved these changes
Mar 18, 2024
Member
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
LGTM, thanks for implementing this 👏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
MustConnectionStringon a variety of DB containers. I skipped MSSQL because that was failing to run tests for me locally.There are probably more I can add them. Should I just add them to all containers with a
ConnectionStringmethod?Why is it important?
Not sure again, just looking at
good first issuetags.#2134
How to test this PR
Run the unit tests.
One point about the unit tests, I could not figure out a way to get a
panicout of theConnectionStringmethods. I looked for ways to corrupt/mutate the exposed_ports and host, but could not figure out an entrypoint. So there is no test that it actually panics if unable to provide the connstring.