generic.go: GenericContainer(): clearer error message#2327
Merged
mdelapenya merged 1 commit intotestcontainers:mainfrom Mar 6, 2024
JordanP:patch-1
Merged
generic.go: GenericContainer(): clearer error message#2327mdelapenya merged 1 commit intotestcontainers:mainfrom JordanP:patch-1
mdelapenya merged 1 commit intotestcontainers:mainfrom
JordanP:patch-1
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
It's customary to prefix an actual Go error with a generic message explaining the error context. Ir looks like it's already done this way everywhere [1] else in the code base, but not here. [1] https://github.com/search?q=repo%3Atestcontainers%2Ftestcontainers-go%20%22failed%20to%20start%20container%22&type=code
mdelapenya
approved these changes
Mar 6, 2024
Member
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
Super tiny and super important change! Thanks for adding consistency 🙇
LGTM
mdelapenya
added a commit
to JJCinAZ/testcontainers-go
that referenced
this pull request
Mar 13, 2024
* main: (239 commits) Move the container and config tests into a test package (testcontainers#2242) Added error handling for context.Canceled in log reading code (testcontainers#2268) chore: updated docker compose version (testcontainers#2340) Add method for getting Weaviate's gRPC port (testcontainers#2339) chore: use withEnv in localstack module (testcontainers#2337) docs: fix wrong copy&paste (testcontainers#2338) fix: consul race on HTTP port (testcontainers#2336) chore(deps): bump mkdocs-material from 8.2.7 to 9.5.13 (testcontainers#2334) feat: add openfga module (testcontainers#2332) chore: retire dependabot (testcontainers#2325) chore: check that the new version is not empty (testcontainers#2331) chore: prepare for next minor development cycle (0.30.0) chore: use new version (v0.29.1) in modules and examples fix: incorrect version chore: prepare for next minor development cycle () chore: use new version (v0.29.0) in modules and examples generic.go: GenericContainer(): clearer error message (testcontainers#2327) chore: confirm support for new mongo images (testcontainers#2326) Add k3s WithManifest option (testcontainers#1920) chore(deps): bump google.golang.org/grpc in /modules/qdrant (testcontainers#2281) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Clearer error message
generic.go: GenericContainer()functionWhy is it important?
It's customary to prefix an actual Go error with a generic message explaining the error context.
It looks like it's already done this way everywhere else in the code base, but not here.