chore(ci): do not fail fast main tests in different Go versions#2210
Merged
mdelapenya merged 2 commits intotestcontainers:mainfrom Feb 14, 2024
Merged
chore(ci): do not fail fast main tests in different Go versions#2210mdelapenya merged 2 commits intotestcontainers:mainfrom
mdelapenya merged 2 commits intotestcontainers:mainfrom
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdelapenya
commented
Feb 14, 2024
mdelapenya
added a commit
to Chris-AS1/testcontainers-go
that referenced
this pull request
Feb 14, 2024
* main: chore(ci): do not fail fast main tests in different Go versions (testcontainers#2210)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes the fail-fast situation when a CI build fails, making all the build in the following matrices to continue:
Why is it important?
Many times the failure could be caused for some flakiness in that particular build, and its sibling could not be affected.
We run all the tests in the two current releases of Go, so if it fails in Go 1.20.x we still want to continue the execution for Go 1.21.x