Merged
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdelapenya
reviewed
Feb 4, 2024
Member
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
This PR looks good to me, thanks for your time contributing the module 👏
Could please remove the examples/consult directory and all the references to it?:
- dependabot
- ci.yml
- vscode workspace
- mkdocs
- sonar.properties
Once there, I think we can merge it. Thanks!
mdelapenya
added
the
feature
mdelapenya
reviewed
Feb 5, 2024
Contributor
Author
|
I noticed there are references to |
Member
Yes please, I can do the toil for you given the case, so feel free to ping me to perform them if needed |
Chris-AS1
commented
Feb 6, 2024
* main: feat (postgres): support for creating and restoring Snapshots (testcontainers#2199) fix: apply volume options only to volumes (testcontainers#2201) redpanda/test: add admin client call (testcontainers#2200) chore(deps): bump cloud.google.com/go/spanner from 1.55.0 to 1.56.0 in /modules/gcloud, cloud.google.com/go/pubsub from 1.35.0 to 1.36.1 in /modules/gcloud, cloud.google.com/go/bigquery from 1.57.1 to 1.58.0 in /modules/gcloud (testcontainers#2197) chore(deps): bump github.com/docker/docker from 25.0.1+incompatible to 25.0.2+incompatible (testcontainers#2196) fix: go doc reference broken image (testcontainers#2195) Add Support for WASM Transforms to Redpanda Module (testcontainers#2170)
* main: chore(ci): do not fail fast main tests in different Go versions (testcontainers#2210)
48 tasks
mdelapenya
approved these changes
Feb 15, 2024
Member
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
LGTM! Thanks for this new module 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the Consul module.
modulegenwas used as starting point, on top of which a couple of methods were added.Why is it important?
This module helps integrate testing with Consul which can be useful to verify the correct behavior under different scenarios.
How to test this PR
Tests are included within the module itself.