fix: fallback matching of registry authentication config#1927
Merged
mdelapenya merged 1 commit intotestcontainers:mainfrom Nov 29, 2023
sermio-te:registry-to-authentication-matching
Merged
fix: fallback matching of registry authentication config#1927mdelapenya merged 1 commit intotestcontainers:mainfrom sermio-te:registry-to-authentication-matching
mdelapenya merged 1 commit intotestcontainers:mainfrom
sermio-te:registry-to-authentication-matching
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdelapenya
reviewed
Nov 28, 2023
Member
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
Thank you for submitting this PR, could you please add tests demonstrating the bug? 🙏
From your PR description I totally understand, but I'd like to have automated tests for the fix, thanks!
sermio-te
commented
Nov 29, 2023
Contributor
Author
Thanks for you prompt response. I added unit tests to cover/verify the new code. |
sermio-te
changed the title
mdelapenya
approved these changes
Nov 29, 2023
Member
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
LGTM! Thanks for this contribution, much appreciated!!
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Nov 30, 2023
* main: (100 commits) fix: fallback matching of registry authentication config (testcontainers#1927) feat: support customizing the Docker build command (testcontainers#1931) docs: include MongoDB's username and password options into the docs (testcontainers#1930) feat: support for custom registry prefixes at the configuration level (testcontainers#1928) Add username and password functions to mongodb (testcontainers#1910) chore: skip TestContainerLogWithErrClosed as flaky on rootless docker (testcontainers#1925) docs: add some Vault module examples (testcontainers#1825) feat: support for executing commands in a container with user, workDir and env (testcontainers#1914) fix(modules.kafka): Switch to MaxInt for 32-bit support (testcontainers#1923) docs: fix code snippet for image substitution (testcontainers#1918) Add database driver note to SQL Wait strategy docs (testcontainers#1916) Reduce flakiness in ClickHouse tests (testcontainers#1902) lint: enable nonamedreturns (testcontainers#1909) chore: deprecate BindMount APIs (testcontainers#1907) fix(reaper): fix race condition when reusing reapers (testcontainers#1904) feat: Allow the container working directory to be specified (testcontainers#1899) chore: make rabbitmq examples more readable (testcontainers#1905) chore(deps): bump github.com/twmb/franz-go and github.com/twmb/franz-go/pkg/kadm in /modules/redpanda (testcontainers#1896) Fix - respect ContainerCustomizer in neo4j module (testcontainers#1903) chore(deps): bump github.com/nats-io/nkeys and github.com/nats-io/nats.go in /modules/nats (testcontainers#1897) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR will fix an issue when config.json contains
authswith keys set to the a registry URL such ashttps://artifactory.com. This way the authentication configuration for the registry will be matched with the configuration file and used.Why is it important?
In case where a registry is configured with an
https://prefix, the authentication to pull images from that registry fails.How to test this PR
Manually add a registry and its authentication config in the
~/.docker/config.jsonand run a test that requires authentication to pull images and start containers.