fix: fix panic when getting container logs#1911
Closed
pmalek wants to merge 1 commit intotestcontainers:mainfrom
Closed
fix: fix panic when getting container logs#1911pmalek wants to merge 1 commit intotestcontainers:mainfrom
pmalek wants to merge 1 commit intotestcontainers:mainfrom
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pmalek
force-pushed
the
fix-panic-when-getting-container-logs
branch
from
546535d to
2a5f2e1
Compare
pmalek
force-pushed
the
fix-panic-when-getting-container-logs
branch
from
2a5f2e1 to
1f20eaf
Compare
Member
|
This PR has been superseded by #1971, please take a look for the changes, and thank you very much for your contribution. Even if not merged, it helped to bring light on the log consumption topic 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a
panicwhen testcontainers cannot get container logs.Appropriate tests have been added in
docker_test.goWhy is it important?
Related issues
Should fix #946
How to test this PR
Follow-ups
Consider changing the types used in
DockerContaineras suggested in #1777 (comment)