modulegen: generate sonar configuration#1644
Merged
mdelapenya merged 1 commit intotestcontainers:mainfrom Sep 19, 2023
mmorel-35:sonarcloud
Merged
modulegen: generate sonar configuration#1644mdelapenya merged 1 commit intotestcontainers:mainfrom mmorel-35:sonarcloud
mdelapenya merged 1 commit intotestcontainers:mainfrom
mmorel-35:sonarcloud
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Matthieu MOREL <[email protected]>
mdelapenya
approved these changes
Sep 19, 2023
Member
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
LGTM, thanks!
At the same time it's weird that sonarqube does not accept glob expressions in the test reports path 🤷
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Sep 20, 2023
* main: fix: proper next version chore: prepare for next minor development cycle () chore: use new version (v0.24.0) in modules and examples fix: include sonarcloud file into the release commit modulegen: generate sonar configuration (testcontainers#1644) feat: define test session semantics (testcontainers#1513) chore(deps): bump actions/checkout from 3 to 4 (testcontainers#1623)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Generate
sonar.go.tests.reportPathsinsonar-project.propertiesWhy is it important?
sonar.go.tests.reportPathsdoesn't supports wilcards so all the paths needs to be listed to avoid seeing this :