feat: support for loading images in the K3s module#1622
Merged
mdelapenya merged 12 commits intotestcontainers:mainfrom Sep 21, 2023
Merged
feat: support for loading images in the K3s module#1622mdelapenya merged 12 commits intotestcontainers:mainfrom
mdelapenya merged 12 commits intotestcontainers:mainfrom
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdelapenya
reviewed
Sep 18, 2023
Member
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
I added just two minor comments, although the one regarding the new PullImage method would need your attention.
Other than that, this PR LGTM, thank you very much for your work here 👏
pablochacin
force-pushed
the
k3s-load-images
branch
from
7847331 to
bc2a01a
Compare
Contributor
Author
|
I added some documentation. |
mdelapenya
previously approved these changes
Sep 18, 2023
Member
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
LGTM, added a few comments, all minor.
Thank you so much for your contribution including testable examples in his to load the images into the cluster. Very helpful!
mdelapenya
reviewed
Sep 19, 2023
Signed-off-by: Pablo Chacin <[email protected]>
Signed-off-by: Pablo Chacin <[email protected]>
Signed-off-by: Pablo Chacin <[email protected]>
Co-authored-by: Manuel de la Peña <[email protected]>
Signed-off-by: Pablo Chacin <[email protected]>
Signed-off-by: Pablo Chacin <[email protected]>
pablochacin
force-pushed
the
k3s-load-images
branch
from
3ff2311 to
f0791ac
Compare
mdelapenya
reviewed
Sep 19, 2023
pablochacin
commented
Sep 19, 2023
Co-authored-by: Manuel de la Peña <[email protected]>
Member
|
Lint failed: I think you can run |
Signed-off-by: Pablo Chacin <[email protected]>
mmorel-35
reviewed
Sep 19, 2023
mmorel-35
reviewed
Sep 19, 2023
Signed-off-by: Pablo Chacin <[email protected]>
Signed-off-by: Pablo Chacin <[email protected]>
Contributor
Author
|
Following a conversation with @mdelapenya The As a result of these simplifications, the |
mdelapenya
reviewed
Sep 20, 2023
mdelapenya
reviewed
Sep 20, 2023
Signed-off-by: Pablo Chacin <[email protected]>
Signed-off-by: Pablo Chacin <[email protected]>
mdelapenya
reviewed
Sep 21, 2023
mdelapenya
approved these changes
Sep 21, 2023
Member
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
LGTM! Thank you for your time contributing to testcontainers-go! 👏
mdelapenya
changed the title
mdelapenya
added a commit
that referenced
this pull request
Sep 25, 2023
…util/v3-3.23.8 * main: chore(deps): bump github.com/IBM/sarama in /modules/kafka (#1637) chore(deps): bump github.com/ClickHouse/clickhouse-go/v2 (#1625) chore(deps): bump github.com/elastic/go-elasticsearch/v8 (#1641) chore(deps): bump github.com/tidwall/gjson from 1.16.0 to 1.17.0 in /modules/couchbase and /modules/vault (#1684) chore(deps): bump mkdocs from 1.5.2 to 1.5.3 (#1662) chore(deps): bump github.com/nats-io/nats.go in /modules/nats (#1657) chore(deps): bump k8s.io/apimachinery from 0.28.1 to 0.28.2 and k8s.io/client-go from 0.28.1 to 0.28.2 in /modules/k3s (#1683) chore(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.18.39 to 1.18.42 and github.com/aws/aws-sdk-go from 1.45.3 to 1.45.15 and github.com/aws/aws-sdk-go-v2/service/s3 from 1.38.5 to 1.39.0 in /modules/localstack (#1680) chore(deps): bump github.com/twmb/franz-go/pkg/kadm from 1.9.0 to 1.9.1 and github.com/twmb/franz-go from 1.14.4 to 1.15.0 in /modules/redpanda (#1682) chore(deps): bump cloud.google.com/go/datastore from 1.13.0 to 1.14.0 and google.golang.org/grpc from 1.58.1 to 1.58.2 and cloud.google.com/go/spanner from 1.47.0 to 1.49.0 in /modules/gcloud (#1681) feat: add GCloud module (#1670) make ryuk timeouts configurable via properties file (#1668) chore(deps): bump mkdocs-material from 8.2.7 to 9.3.2 (#1649) chore(deps): bump google.golang.org/grpc from 1.57.0 to 1.58.1 and google.golang.org/api from 0.138.0 to 0.142.0 in /examples (#1667) feat: support for loading images in the K3s module (#1622)
mdelapenya
added a commit
that referenced
this pull request
Sep 26, 2023
….com/docker/compose/v2-2.22.0 * main: chore(deps): bump golang.org/x/text to v0.15.0 (#1687) chore(deps): bump github.com/shirou/gopsutil/v3 from 3.23.7 to 3.23.8 (#1651) Wait for k3s node to sync (#1685) chore(deps): bump github.com/IBM/sarama in /modules/kafka (#1637) chore(deps): bump github.com/ClickHouse/clickhouse-go/v2 (#1625) chore(deps): bump github.com/elastic/go-elasticsearch/v8 (#1641) chore(deps): bump github.com/tidwall/gjson from 1.16.0 to 1.17.0 in /modules/couchbase and /modules/vault (#1684) chore(deps): bump mkdocs from 1.5.2 to 1.5.3 (#1662) chore(deps): bump github.com/nats-io/nats.go in /modules/nats (#1657) chore(deps): bump k8s.io/apimachinery from 0.28.1 to 0.28.2 and k8s.io/client-go from 0.28.1 to 0.28.2 in /modules/k3s (#1683) chore(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.18.39 to 1.18.42 and github.com/aws/aws-sdk-go from 1.45.3 to 1.45.15 and github.com/aws/aws-sdk-go-v2/service/s3 from 1.38.5 to 1.39.0 in /modules/localstack (#1680) chore(deps): bump github.com/twmb/franz-go/pkg/kadm from 1.9.0 to 1.9.1 and github.com/twmb/franz-go from 1.14.4 to 1.15.0 in /modules/redpanda (#1682) chore(deps): bump cloud.google.com/go/datastore from 1.13.0 to 1.14.0 and google.golang.org/grpc from 1.58.1 to 1.58.2 and cloud.google.com/go/spanner from 1.47.0 to 1.49.0 in /modules/gcloud (#1681) feat: add GCloud module (#1670) make ryuk timeouts configurable via properties file (#1668) chore(deps): bump mkdocs-material from 8.2.7 to 9.3.2 (#1649) chore(deps): bump google.golang.org/grpc from 1.57.0 to 1.58.1 and google.golang.org/api from 0.138.0 to 0.142.0 in /examples (#1667) feat: support for loading images in the K3s module (#1622)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a function to k3s module for loading images into the k3s cluster.
It also adds helper functions for manipulating images to the docker provider, to facilitate testing.
Why is it important?
When testing images generated locally (for example, in a CI/CD workflow), it would be convenient not to have to push them to a repository in order to make them available to the k3s test container. Instead, the test should be able tp upload the images to the test container.
Related issues