ci(sonarcloud): upload artifact#1614
ci(sonarcloud): upload artifact#1614mdelapenya merged 6 commits intotestcontainers:mainfrom mmorel-35:patch-1
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
This LGTM, although before approving I'd like to first discuss https://github.com/testcontainers/testcontainers-go/pull/1614/files#r1324001839
Right after that, I think this is ready to go.
Again, probably this is not adding features to the end-users, but adding lots of value to the maintainability of the project 🚀, which makes a lot for me. Thanks!!!
|
By the way, you’ll need to update the pre release script so the version is also updated in sonar properties |
Will do it in a follow-up, thanks! |
|
@mmorel-35 here you have it: #1615 |
* main: up (testcontainers#1617) chore: update sonarcloud properties when releasing the project (testcontainers#1615) ci(sonarcloud): upload artifact (testcontainers#1614)
2 participants
What does this PR do?
Uploads unit-tests.xml and coverage.out in the sonarcloud artifact during the test phase. After the test-examples job the sonarcloud scan is executed with the artifacts uploaded.
Why is it important?
This helps providing a correct code coverage on sonarcloud