chore(deps): bump github.com/hashicorp/vault-client-go in /modules/vault by mmorel-35 · Pull Request #1566 · testcontainers/testcontainers-go

mmorel-35 · 2023-08-31T17:49:33Z

What does this PR do?

Updates vault-client-go to 0.3.3

Why is it important?

Stay up to date

netlify · 2023-08-31T17:49:38Z

✅ Deploy Preview for testcontainers-go ready!

Name	Link
🔨 Latest commit	`eb95f95`
🔍 Latest deploy log	https://app.netlify.com/sites/testcontainers-go/deploys/64fdf9811a85a30008febbe7
😎 Deploy Preview	https://deploy-preview-1566--testcontainers-go.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mdelapenya · 2023-08-31T17:52:14Z

I think this is probably related: #1489 (comment)

Did the tests run and pass in your machine?

mmorel-35 · 2023-08-31T17:55:22Z

Did the tests run and pass in your machine?

Not Yet !
For the moment, I have

.\vault_test.go:105:32: invalid operation: cannot index s.Data (variable of type schema.KvV2ReadResponse)
.\vault_test.go:128:31: invalid operation: cannot index s.Data (variable of type schema.KvV2ReadResponse)

After adding .Data, I have now :

vault_test.go:104: 
        	Error Trace:	/home/runner/work/testcontainers-go/testcontainers-go/modules/vault/vault_test.go:104
        	Error:      	Expected nil, but got: &vault.ResponseError{StatusCode:404, Errors:[]string{"no handler for route \"kv-v2/data/test1\". route entry not found."}, OriginalRequest:(*http.Request)(0xc000207[50](https://github.com/testcontainers/testcontainers-go/actions/runs/6041009438/job/16393799572#step:10:51)0)}
        	Test:       	TestVaultGetSecretPathWithClient
--- FAIL: TestVaultGetSecretPathWithClient (0.00s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0x9771be]

goroutine 164 [running]:
testing.tRunner.func1.2({0x9fd060, 0xf2[51](https://github.com/testcontainers/testcontainers-go/actions/runs/6041009438/job/16393799572#step:10:52)f0})
	/opt/hostedtoolcache/go/1.20.7/x64/src/testing/testing.go:1[52](https://github.com/testcontainers/testcontainers-go/actions/runs/6041009438/job/16393799572#step:10:53)6 +0x24e
testing.tRunner.func1()
	/opt/hostedtoolcache/go/1.20.7/x64/src/testing/testing.go:1529 +0x39f
panic({0x9fd060, 0xf251f0})
	/opt/hostedtoolcache/go/1.20.7/x64/src/runtime/panic.go:884 +0x213
github.com/testcontainers/testcontainers-go/modules/vault_test.TestVaultGetSecretPathWithClient(0x1?)
	/home/runner/work/testcontainers-go/testcontainers-go/modules/vault/vault_test.go:105 +0x17e
testing.tRunner(0xc0003cab60, 0xaeace0)
	/opt/hostedtoolcache/go/1.20.7/x64/src/testing/testing.go:1[57](https://github.com/testcontainers/testcontainers-go/actions/runs/6041009438/job/16393799572#step:10:58)6 +0x10b
created by testing.(*T).Run
	/opt/hostedtoolcache/go/1.20.7/x64/src/testing/testing.go:1[62](https://github.com/testcontainers/testcontainers-go/actions/runs/6041009438/job/16393799572#step:10:63)9 +0x3ea

Any suggestion @mdelapenya ?

Bumps [github.com/hashicorp/vault-client-go](https://github.com/hashicorp/vault-client-go) from 0.2.0 to 0.3.3. - [Release notes](https://github.com/hashicorp/vault-client-go/releases) - [Changelog](https://github.com/hashicorp/vault-client-go/blob/main/CHANGELOG.md) - [Commits](hashicorp/vault-client-go@v0.2.0...v0.3.3) --- updated-dependencies: - dependency-name: github.com/hashicorp/vault-client-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

modules/vault/vault_test.go

sonarqubecloud · 2023-09-10T17:15:19Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

mmorel-35 · 2023-09-11T07:44:46Z

Hi @mdelapenya ,
The tests are passing now ;) !

mdelapenya

Great you found how to fix that error! I'm updating #1603 with these changes

Thanks!

…ult (testcontainers#1566) * chore(deps): bump github.com/hashicorp/vault-client-go in /modules/vault Bumps [github.com/hashicorp/vault-client-go](https://github.com/hashicorp/vault-client-go) from 0.2.0 to 0.3.3. - [Release notes](https://github.com/hashicorp/vault-client-go/releases) - [Changelog](https://github.com/hashicorp/vault-client-go/blob/main/CHANGELOG.md) - [Commits](hashicorp/vault-client-go@v0.2.0...v0.3.3) --- updated-dependencies: - dependency-name: github.com/hashicorp/vault-client-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * up * Update vault_test.go * Update vault_test.go * Update vault_test.go * Update vault_test.go * Update vault_test.go --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Manuel de la Peña <[email protected]>

* main: ci(lint): enable errorlint linter (testcontainers#1604) ci(lint): enable gocritic linter (testcontainers#1605) chore(deps): bump github.com/hashicorp/vault-client-go in /modules/vault (testcontainers#1566)

* fix: rename vault container in tests * chore: adjust comment in template * docs(vault): use RunContainer example in usage section * docs: update vault docs * docs: add RunContainer example for redpanda * docs: add RunContainer example for redis * docs: document creating networks * docs: add RunContainer example for pulsar * docs: add RunContainer example for postgres * docs: add RunContainer example for neo4j * docs: add RunContainer example for nats * docs: update quickstart to not use testing libraries * docs: add RunContainer example for mysql * docs: add RunContainer example for mongo * docs: add RunContainer example for mariadb * chore: use logger to print out hostname external reason * docs: document new Go examples file * docs: add RunContainer example for localstack * chore: convert k3s test into a testable example * chore: convert mongodb test into testable example * fix: handle errors in example tests for elasticsearch * fix: do not deprecate used fields They are not directly called, but the customisers are populating their values * chore: convert couchbase test into testable example * chore: convert clickhouse test into testable example * docs: adjust artemis docs * chore: simplify postgres example * fix: lint * chore(deps): bump github.com/hashicorp/vault-client-go in /modules/vault (#1566) * chore(deps): bump github.com/hashicorp/vault-client-go in /modules/vault Bumps [github.com/hashicorp/vault-client-go](https://github.com/hashicorp/vault-client-go) from 0.2.0 to 0.3.3. - [Release notes](https://github.com/hashicorp/vault-client-go/releases) - [Changelog](https://github.com/hashicorp/vault-client-go/blob/main/CHANGELOG.md) - [Commits](hashicorp/vault-client-go@v0.2.0...v0.3.3) --- updated-dependencies: - dependency-name: github.com/hashicorp/vault-client-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * up * Update vault_test.go * Update vault_test.go * Update vault_test.go * Update vault_test.go * Update vault_test.go --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Manuel de la Peña <[email protected]> * ci(lint): enable gocritic linter (#1605) Signed-off-by: Matthieu MOREL <[email protected]> * ci(lint): enable errorlint linter (#1604) * ci(lint): enable errorlint linter Signed-off-by: Matthieu MOREL <[email protected]> * Apply suggestions from code review Co-authored-by: Manuel de la Peña <[email protected]> --------- Signed-off-by: Matthieu MOREL <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]> * fix: handle errors * chore(pulsar): create/remove the network properly * chore: better container logs on errors during startup * Revert "chore: better container logs on errors during startup" This reverts commit 0e28881. * chore: better container logs on errors during startup * fix: do not wrap error but print it * fix: avoid polluting default wait strategies in pulsar --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Matthieu MOREL <[email protected]> Co-authored-by: Matthieu MOREL <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* main: chore: always generate the examples including a explicit image (testcontainers#1611) chore: support linting all modules locally (testcontainers#1609) ci(sonarcloud): run only when not root-less (testcontainers#1608) remove extra equal in sonar.organization (testcontainers#1607) chore(ci): enable code coverage on Sonarcloud (testcontainers#1518) docs: use Go testable examples in modules (testcontainers#1603) ci(lint): enable errorlint linter (testcontainers#1604) ci(lint): enable gocritic linter (testcontainers#1605) chore(deps): bump github.com/hashicorp/vault-client-go in /modules/vault (testcontainers#1566) ci(security): setup codeql scan (testcontainers#1606) chore(deps): bump github.com/cyphar/filepath-securejoin (testcontainers#1601) chore: generate Go examples for new modules (testcontainers#1600) chore: generate Go examples for new modules (testcontainers#1600)

* fix: rename vault container in tests * chore: adjust comment in template * docs(vault): use RunContainer example in usage section * docs: update vault docs * docs: add RunContainer example for redpanda * docs: add RunContainer example for redis * docs: document creating networks * docs: add RunContainer example for pulsar * docs: add RunContainer example for postgres * docs: add RunContainer example for neo4j * docs: add RunContainer example for nats * docs: update quickstart to not use testing libraries * docs: add RunContainer example for mysql * docs: add RunContainer example for mongo * docs: add RunContainer example for mariadb * chore: use logger to print out hostname external reason * docs: document new Go examples file * docs: add RunContainer example for localstack * chore: convert k3s test into a testable example * chore: convert mongodb test into testable example * fix: handle errors in example tests for elasticsearch * fix: do not deprecate used fields They are not directly called, but the customisers are populating their values * chore: convert couchbase test into testable example * chore: convert clickhouse test into testable example * docs: adjust artemis docs * chore: simplify postgres example * fix: lint * chore(deps): bump github.com/hashicorp/vault-client-go in /modules/vault (testcontainers#1566) * chore(deps): bump github.com/hashicorp/vault-client-go in /modules/vault Bumps [github.com/hashicorp/vault-client-go](https://github.com/hashicorp/vault-client-go) from 0.2.0 to 0.3.3. - [Release notes](https://github.com/hashicorp/vault-client-go/releases) - [Changelog](https://github.com/hashicorp/vault-client-go/blob/main/CHANGELOG.md) - [Commits](hashicorp/vault-client-go@v0.2.0...v0.3.3) --- updated-dependencies: - dependency-name: github.com/hashicorp/vault-client-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * up * Update vault_test.go * Update vault_test.go * Update vault_test.go * Update vault_test.go * Update vault_test.go --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Manuel de la Peña <[email protected]> * ci(lint): enable gocritic linter (testcontainers#1605) Signed-off-by: Matthieu MOREL <[email protected]> * ci(lint): enable errorlint linter (testcontainers#1604) * ci(lint): enable errorlint linter Signed-off-by: Matthieu MOREL <[email protected]> * Apply suggestions from code review Co-authored-by: Manuel de la Peña <[email protected]> --------- Signed-off-by: Matthieu MOREL <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]> * fix: handle errors * chore(pulsar): create/remove the network properly * chore: better container logs on errors during startup * Revert "chore: better container logs on errors during startup" This reverts commit 0e28881. * chore: better container logs on errors during startup * fix: do not wrap error but print it * fix: avoid polluting default wait strategies in pulsar --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Matthieu MOREL <[email protected]> Co-authored-by: Matthieu MOREL <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

mmorel-35 requested a review from a team as a code owner August 31, 2023 17:49

mmorel-35 marked this pull request as draft August 31, 2023 18:02

dependabot bot and others added 5 commits September 2, 2023 10:37

up

b7ae9f0

Update vault_test.go

8a68a85

Update vault_test.go

dae703a

Update vault_test.go

3172369

mmorel-35 commented Sep 2, 2023

View reviewed changes

modules/vault/vault_test.go Outdated Show resolved Hide resolved

mmorel-35 and others added 4 commits September 2, 2023 11:02

Update vault_test.go

61b0e4a

Merge branch 'main' into update/vault-client-go-0.3.3

c3cd25c

Merge branch 'main' into update/vault-client-go-0.3.3

2098f59

Update vault_test.go

eb95f95

mmorel-35 marked this pull request as ready for review September 10, 2023 17:24

mdelapenya self-assigned this Sep 11, 2023

mdelapenya added the dependencies Dependencies or external services label Sep 11, 2023

mdelapenya approved these changes Sep 11, 2023

View reviewed changes

mdelapenya merged commit 0f2d1f3 into testcontainers:main Sep 11, 2023

mmorel-35 deleted the update/vault-client-go-0.3.3 branch September 11, 2023 08:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(deps): bump github.com/hashicorp/vault-client-go in /modules/vault#1566

chore(deps): bump github.com/hashicorp/vault-client-go in /modules/vault#1566
mdelapenya merged 9 commits intotestcontainers:mainfrom
mmorel-35:update/vault-client-go-0.3.3

mmorel-35 commented Aug 31, 2023

Uh oh!

netlify bot commented Aug 31, 2023 •

edited

Loading

Uh oh!

mdelapenya commented Aug 31, 2023

Uh oh!

mmorel-35 commented Aug 31, 2023 •

edited

Loading

Uh oh!

Uh oh!

sonarqubecloud bot commented Sep 10, 2023

Uh oh!

mmorel-35 commented Sep 11, 2023

Uh oh!

mdelapenya left a comment •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

mmorel-35 commented Aug 31, 2023

What does this PR do?

Why is it important?

Uh oh!

netlify bot commented Aug 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for testcontainers-go ready!

Uh oh!

mdelapenya commented Aug 31, 2023

Uh oh!

mmorel-35 commented Aug 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Sep 10, 2023

Uh oh!

mmorel-35 commented Sep 11, 2023

Uh oh!

mdelapenya left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify bot commented Aug 31, 2023 •

edited

Loading

mmorel-35 commented Aug 31, 2023 •

edited

Loading

mdelapenya left a comment •

edited

Loading