chore: refine fail-fast strategy on CI#1555
Merged
mdelapenya merged 9 commits intotestcontainers:mainfrom Aug 30, 2023
Merged
Conversation
We do not want to abort all the modules if/when one is flaky. The rest of matrices will still fail fast
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mmorel-35
reviewed
Aug 30, 2023
mmorel-35
reviewed
Aug 30, 2023
It will run golangci-lint for them
* main: fix: remove wrong example from workspace (testcontainers#1556)
mmorel-35
reviewed
Aug 30, 2023
Co-authored-by: Matthieu MOREL <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Aug 30, 2023
* main: chore: refine fail-fast strategy on CI (testcontainers#1555)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a new input parameter to the reusable workflow to run the Go tests, making it possible to call it with a fail-fast strategy.
At the same time, we are not running the Go examples (modules that do not expose any API, just code snippets) in one single version of Go: 1.20.x, and only in Ubuntu.
Why is it important?
The first change tries to avoid the cancellation of the entire matrix for modules, which could happen if a flaky build fails: the rest of those 60 builds will be cancelled.
The second change is to save GH workers, as examples as less critical in terms of build conditions. We will reduce by 4 the number of user workers for the examples: Given there are 10 examples, instead of 40 builds, we will have just 10.