modulegen: create internal/mkdocs#1504
modulegen: create internal/mkdocs#1504mdelapenya merged 2 commits intotestcontainers:mainfrom mmorel-35:modulegen/mkdocs
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mmorel-35
changed the title
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
LGTM!, just a comment, not a blocker, regarding one function. Other than that, great job extracting code! 💪
|
By the way, I noticed that there is no |
Indeed, it's on purpose as we do have a separate page in https://golang.testcontainers.org/features/docker_compose/. But I think it would be a good idea to add it to the modules and reduce the number of corner cases across code generation. I'll do it in a separate PR. Thanks for pointing this out! |
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
LGTM! Only a final change in a method name: there was a typo and making the name a bit more consistent.
Other than that, once this is addressed, we are ready to merge
|
@mdelapenya , |
Signed-off-by: Matthieu MOREL <[email protected]>
Co-authored-by: Manuel de la Peña <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
|
Hi @mdelapenya , The tests were passing before the rebase, something happened with the two last commits on the main branch ? |
Not necessarily with the two commit :) I always take a look at the workflow: 
Because we run against the last two active versions of Go, I check both on Ubuntu: if one passes and the other not, then it seems certain flakiness to me. Same for the modules. |
|
Good news :) !! |
| } | ||
|
|
||
| func generate(example Example, rootDir string) error { | ||
| func generate(example Example, ctx *Context) error { |
There was a problem hiding this comment.
I did not notice this: for consistency, let's pass the context as first arg.
But let's do this in a separate PR in order to merge this one as is :)
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
LGTM, thanks for your hard work adding maintainability to the code generation tool 👏
* main: (26 commits) modulegen: create internal/make (testcontainers#1537) chore: fix workflow (testcontainers#1538) chore(deps): bump the all group in /examples/cockroachdb with 1 update (testcontainers#1522) chore(deps): bump the all group in /examples/bigtable with 1 update (testcontainers#1534) chore(deps): bump the all group in /modules/localstack with 4 updates (testcontainers#1535) chore(deps): bump the all group in /modules/k3s with 2 updates (testcontainers#1526) chore(deps): bump the all group in /examples/spanner with 2 updates (testcontainers#1532) chore(deps): bump the all group in /examples/firestore with 1 update (testcontainers#1523) chore(deps): bump the all group in /modules/redis with 1 update (testcontainers#1524) chore(deps): bump the all group in /modules/clickhouse with 1 update (testcontainers#1525) chore(deps): bump the all group in /examples/toxiproxy with 2 updates (testcontainers#1528) chore(deps): bump the all group in /examples/pubsub with 1 update (testcontainers#1531) chore(deps): bump the all group in /examples/datastore with 2 updates (testcontainers#1530) chore(deps): bump the all group in /modules/redpanda with 1 update (testcontainers#1527) chore: properly render mkdocs.yml (testcontainers#1521) modulegen: create internal/workflow (testcontainers#1520) modulegen: create internal/module (testcontainers#1505) modulegen: create internal/mkdocs (testcontainers#1504) fix: do not remove the file schema in docker.host property (testcontainers#1517) fix: reset config in tests (testcontainers#1516) ...
2 participants
Refactor mkdocs code in modulegen