test: fix TestGetDockerConfig#1413
Merged
mdelapenya merged 1 commit intotestcontainers:mainfrom Aug 2, 2023
Merged
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Do not assume non-empty auths section in local config file but test that getDockerConfig returns default config when DOCKER_CONFIG env variable is not set. Also remove t.Cleanup calls that restore env variables because t.Setenv restores them itself.
AlexanderYastrebov
force-pushed
the
test/fix-get-docker-config
branch
from
e78a13d to
5ab94b8
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Aug 3, 2023
* main: chore(deps): bump github.com/hashicorp/consul/api in /examples/consul (testcontainers#1381) chore(deps): bump github.com/twmb/franz-go in /modules/redpanda (testcontainers#1387) chore(deps): bump github.com/nats-io/nats.go in /examples/nats (testcontainers#1389) feat(redpanda): Add option to enable topic auto-creation (testcontainers#1360) chore(deps): bump golang.org/x/text from 0.9.0 to 0.11.0 in /modulegen (testcontainers#1388) chore(deps): bump google.golang.org/api from 0.125.0 to 0.134.0 in /examples (testcontainers#1412) chore(deps): bump golang.org/x/mod and github.com/aws/aws-sdk-go-v2/config in /modules/localstack (testcontainers#1410) test: fix TestGetDockerConfig (testcontainers#1413)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Do not assume non-empty auths section in local config file but test that getDockerConfig returns default config when DOCKER_CONFIG env variable is not set.
Also remove t.Cleanup calls that restore env variables because t.Setenv restores them itself.
Why is it important?
Fixes failing test that depends on local environment.
Related issues