feat(redpanda): Add option to enable topic auto-creation#1360
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ladislavmacoun
force-pushed
the
feat/allow-auto-topic-creation
branch
4 times, most recently
from
963f3e9 to
fb331cb
Compare
|
Thanks for your contribution! So far, I haven't been able to find any reference about .bootstrap.yml. can you share why it is needed in both places? I only found the redpanda.yml config but when enabled only there nothing happens. I would like to understand more about it. |
The bootstrapping mechanism is mentioned in the production deployment documentation, there is a reference in the code for bootstrap.yaml configuration. My understanding of this is that the bootstrap.yaml is responsible for the configuration of the entire cluster, and it is only assessed at the time of the initial start-up. On the other hand, adjustments can be made to the redpanda.yaml config as needed. |
ladislavmacoun
force-pushed
the
feat/allow-auto-topic-creation
branch
from
fb331cb to
b3ecfa1
Compare
ladislavmacoun
force-pushed
the
feat/allow-auto-topic-creation
branch
from
b3ecfa1 to
844aa73
Compare
The option to enable automatic topic creation is particularly useful for testing environments, allowing users to produce data into topics without the need to create them beforehand. Signed-off-by: Ladislav Macoun <[email protected]>
Signed-off-by: Ladislav Macoun <[email protected]>
ladislavmacoun
force-pushed
the
feat/allow-auto-topic-creation
branch
from
844aa73 to
621b475
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
This PR LGTM! Although I'd like to postpone the final approval to @eddumelendez, who had some other concerns.
Thanks for your time and patience!
|
Great work! 💪 |
* main: chore(deps): bump github.com/hashicorp/consul/api in /examples/consul (testcontainers#1381) chore(deps): bump github.com/twmb/franz-go in /modules/redpanda (testcontainers#1387) chore(deps): bump github.com/nats-io/nats.go in /examples/nats (testcontainers#1389) feat(redpanda): Add option to enable topic auto-creation (testcontainers#1360) chore(deps): bump golang.org/x/text from 0.9.0 to 0.11.0 in /modulegen (testcontainers#1388) chore(deps): bump google.golang.org/api from 0.125.0 to 0.134.0 in /examples (testcontainers#1412) chore(deps): bump golang.org/x/mod and github.com/aws/aws-sdk-go-v2/config in /modules/localstack (testcontainers#1410) test: fix TestGetDockerConfig (testcontainers#1413)
3 participants
What does this PR do?
Adds an option to enable topic auto-creation
Why is it important?
The option to enable automatic topic creation is particularly useful for testing environments, allowing users to produce data into topics without the need to create them beforehand.