Revert "fix: don't panic when logs waits for more than 5 seconds (#947)"#1164
Merged
mdelapenya merged 1 commit intotestcontainers:mainfrom May 10, 2023
Merged
Revert "fix: don't panic when logs waits for more than 5 seconds (#947)"#1164mdelapenya merged 1 commit intotestcontainers:mainfrom
mdelapenya merged 1 commit intotestcontainers:mainfrom
Conversation
…tcontainers#947)" This reverts commit 5185956.
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced May 10, 2023
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
May 11, 2023
* main: docs: enrich docs for modules (testcontainers#1167) chore: prepare for next minor development cycle (0.21.0) chore: use new version (v0.20.1) in modules and examples Revert "fix: don't panic when logs waits for more than 5 seconds (testcontainers#947)" (testcontainers#1164) fix: define a two-phase release process (testcontainers#1163) ci(lint): enable misspell and gci linters (testcontainers#1162)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This reverts commit 5185956.
Why is it important?
We identified that the changes in the logic changed the behaviour of the StartProducer method causing the StartStop test for the log consumers to fail in a non-consistent manner (flakiness).
After debugging the issue for a while, and instead of commenting/skipping the test, I decided to revert the original commit from #947 until we get to a deterministic behaviour.
Please see:
Related issues