Skip to content

ci(lint): enable misspell and gci linters#1162

Merged
mdelapenya merged 2 commits intotestcontainers:mainfrom
mmorel-35:linters
May 9, 2023
Merged

ci(lint): enable misspell and gci linters#1162
mdelapenya merged 2 commits intotestcontainers:mainfrom
mmorel-35:linters

Conversation

@mmorel-35
Copy link
Copy Markdown
Contributor

@mmorel-35 mmorel-35 commented May 9, 2023

What does this PR do?

Enables misspell and gci linters

Why is it important?

Fixes and prevent misspellings and organize in a fixed order the dependencies imports.

mmorel-35 added 2 commits May 9, 2023 10:02
@mmorel-35
enable gci linter
5c76b67 
Signed-off-by: Matthieu MOREL <[email protected]>
@mmorel-35
enable misspell linter
109907f 
Signed-off-by: Matthieu MOREL <[email protected]>
@mmorel-35 mmorel-35 requested a review from a team as a code owner May 9, 2023 09:49
@netlify
Copy link
Copy Markdown

netlify bot commented May 9, 2023 •
edited
Loading

✅ Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 109907f
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/645a173887c99300078494eb
😎 Deploy Preview https://deploy-preview-1162--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented May 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

mdelapenya
mdelapenya approved these changes May 9, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this tiny and super valuable contribution!!

I've been thinking about it since ever, so super glad you had the time to add them to our golangci config 👏

LGTM 👍

image

@mmorel-35
Copy link
Copy Markdown
Contributor Author

mmorel-35 commented May 9, 2023 •
edited
Loading

Hi @mdelapenya,

Do you have a list of linters you would like to add ?
I can give it a try.

@mdelapenya
Copy link
Copy Markdown
Member

mdelapenya commented May 9, 2023

Hi @mdelapenya,

Do you have a list of linters you would like to add ? I can give it a try.

Not at this moment but the spell checker you added here.

If you want to add one or more, let's open a discussion with it. wdyt?

BTW, I'm merging this little one now 🚀 thanks!

@mmorel-35
Copy link
Copy Markdown
Contributor Author

mmorel-35 commented May 9, 2023

If you want to add one or more, let's open a discussion with it. wdyt?

OK !

@mdelapenya mdelapenya self-assigned this May 9, 2023
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label May 9, 2023
@mdelapenya mdelapenya merged commit 6c3b1e5 into testcontainers:main May 9, 2023
@mmorel-35 mmorel-35 deleted the linters branch May 9, 2023 15:15
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request May 11, 2023
@mdelapenya
Merge branch 'main' into rootless-docker
cd59f79 
* main:
  docs: enrich docs for modules (testcontainers#1167)
  chore: prepare for next minor development cycle (0.21.0)
  chore: use new version (v0.20.1) in modules and examples
  Revert "fix: don't panic when logs waits for more than 5 seconds (testcontainers#947)" (testcontainers#1164)
  fix: define a two-phase release process (testcontainers#1163)
  ci(lint): enable misspell and gci linters (testcontainers#1162)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdelapenya mdelapenya mdelapenya approved these changes

Assignees

@mdelapenya mdelapenya

Labels

chore Changes that do not impact the existing functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mmorel-35 @mdelapenya