docs: document tc_host inside the networking section#1041
Merged
mdelapenya merged 2 commits intotestcontainers:mainfrom Apr 11, 2023
sgloutnikov:document_tc_host
Merged
docs: document tc_host inside the networking section#1041mdelapenya merged 2 commits intotestcontainers:mainfrom sgloutnikov:document_tc_host
mdelapenya merged 2 commits intotestcontainers:mainfrom
sgloutnikov:document_tc_host
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
mdelapenya
reviewed
Apr 11, 2023
Co-authored-by: Manuel de la Peña <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
Author
|
Much better with the |
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Apr 13, 2023
* main: Add support for LocalStack v2 (testcontainers#994) docs: document tc_host inside the networking section (testcontainers#1041)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Document the
TC_HOSTenvironment variable in the container networking section.Why is it important?
Our CI Kubernetes runners were incorrectly returning
localhostvia theHostcall. After going through thedocker.gocode I noticed there is a manual override via theTC_HOSTENV variable. Document this so it's more visible in the future.