-
-
Notifications
You must be signed in to change notification settings - Fork 600
Containers created by Docker Compose are not cleaned by Ryuk #372
Copy link
Copy link
Closed
Labels
composeDocker Compose.Docker Compose.good first issueWant to contribute to testcontainers? Start from hereWant to contribute to testcontainers? Start from herehacktoberfestPull Requests accepted for Hacktoberfest.Pull Requests accepted for Hacktoberfest.
Description
Containers created and started by testcontainers-go through Docker Compose are not guaranteed to be cleaned up (and this is something I personally observed when running the testcontainers-go test suite on WSL), since Ryuk is not aware of them.
We solved this issue in testcontainers-java by registering the project label added by Docker Compose with Ryuk:
https://github.com/testcontainers/testcontainers-java/blob/76f11b344ce42ad920828b0628a7ec929a9d0eca/core/src/main/java/org/testcontainers/containers/DockerComposeContainer.java#L312
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
composeDocker Compose.Docker Compose.good first issueWant to contribute to testcontainers? Start from hereWant to contribute to testcontainers? Start from herehacktoberfestPull Requests accepted for Hacktoberfest.Pull Requests accepted for Hacktoberfest.