Skip to content

Containers created by Docker Compose are not cleaned by Ryuk #372

@kiview

Description

@kiview

Containers created and started by testcontainers-go through Docker Compose are not guaranteed to be cleaned up (and this is something I personally observed when running the testcontainers-go test suite on WSL), since Ryuk is not aware of them.

We solved this issue in testcontainers-java by registering the project label added by Docker Compose with Ryuk:
https://github.com/testcontainers/testcontainers-java/blob/76f11b344ce42ad920828b0628a7ec929a9d0eca/core/src/main/java/org/testcontainers/containers/DockerComposeContainer.java#L312

Metadata

Metadata

Assignees

No one assigned

    Labels

    composeDocker Compose.good first issueWant to contribute to testcontainers? Start from herehacktoberfestPull Requests accepted for Hacktoberfest.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions