-
-
Notifications
You must be signed in to change notification settings - Fork 601
[Bug]: Consider handling non-existent ~/.docker/config.json #2767
Description
Testcontainers version
v0.33.0
Using the latest Testcontainers version?
Yes
Host OS
Ubuntu 24.04.1 LTS
Host arch
x86
Go version
1.22
Docker version
Client: Docker Engine - Community
Version: 27.2.0
API version: 1.46 (downgraded from 1.47)
Go version: go1.21.13
Git commit: 3ab4256
Built: Tue Aug 27 14:15:15 2024
OS/Arch: linux/amd64
Context: desktop-linux
Server: Docker Desktop 4.33.0 (160616)
Engine:
Version: 27.1.1
API version: 1.46 (minimum version 1.24)
Go version: go1.21.12
Git commit: cc13f95
Built: Tue Jul 23 19:57:19 2024
OS/Arch: linux/amd64
Experimental: false
containerd:
Version: 1.7.19
GitCommit: 2bf793ef6dc9a18e00cb12efb64355c2c9d5eb41
runc:
Version: 1.7.19
GitCommit: v1.1.13-0-g58aa920
docker-init:
Version: 0.19.0
GitCommit: de40ad0Docker info
Client: Docker Engine - Community
Version: 27.2.0
Context: desktop-linux
Debug Mode: false
Plugins:
buildx: Docker Buildx (Docker Inc.)
Version: v0.16.1-desktop.1
Path: /usr/lib/docker/cli-plugins/docker-buildx
compose: Docker Compose (Docker Inc.)
Version: v2.29.1-desktop.1
Path: /usr/lib/docker/cli-plugins/docker-compose
debug: Get a shell into any image or container (Docker Inc.)
Version: 0.0.34
Path: /usr/lib/docker/cli-plugins/docker-debug
desktop: Docker Desktop commands (Alpha) (Docker Inc.)
Version: v0.0.14
Path: /usr/lib/docker/cli-plugins/docker-desktop
dev: Docker Dev Environments (Docker Inc.)
Version: v0.1.2
Path: /usr/lib/docker/cli-plugins/docker-dev
extension: Manages Docker extensions (Docker Inc.)
Version: v0.2.25
Path: /usr/lib/docker/cli-plugins/docker-extension
feedback: Provide feedback, right in your terminal! (Docker Inc.)
Version: v1.0.5
Path: /usr/lib/docker/cli-plugins/docker-feedback
init: Creates Docker-related starter files for your project (Docker Inc.)
Version: v1.3.0
Path: /usr/lib/docker/cli-plugins/docker-init
sbom: View the packaged-based Software Bill Of Materials (SBOM) for an image (Anchore Inc.)
Version: 0.6.0
Path: /usr/lib/docker/cli-plugins/docker-sbom
scout: Docker Scout (Docker Inc.)
Version: v1.11.0
Path: /usr/lib/docker/cli-plugins/docker-scout
Server:
Containers: 0
Running: 0
Paused: 0
Stopped: 0
Images: 11
Server Version: 27.1.1
Storage Driver: overlay2
Backing Filesystem: extfs
Supports d_type: true
Using metacopy: false
Native Overlay Diff: true
userxattr: false
Logging Driver: json-file
Cgroup Driver: cgroupfs
Cgroup Version: 2
Plugins:
Volume: local
Network: bridge host ipvlan macvlan null overlay
Log: awslogs fluentd gcplogs gelf journald json-file local splunk syslog
Swarm: inactive
Runtimes: runc io.containerd.runc.v2
Default Runtime: runc
Init Binary: docker-init
containerd version: 2bf793ef6dc9a18e00cb12efb64355c2c9d5eb41
runc version: v1.1.13-0-g58aa920
init version: de40ad0
Security Options:
seccomp
Profile: unconfined
cgroupns
Kernel Version: 6.10.0-linuxkit
Operating System: Docker Desktop
OSType: linux
Architecture: x86_64
CPUs: 16
Total Memory: 14.88GiB
Name: docker-desktop
ID: b8d41dab-9cfc-4d99-a8ba-66a0a767d1b1
Docker Root Dir: /var/lib/docker
Debug Mode: false
HTTP Proxy: http.docker.internal:3128
HTTPS Proxy: http.docker.internal:3128
No Proxy: hubproxy.docker.internal
Experimental: false
Insecure Registries:
hubproxy.docker.internal:5555
127.0.0.0/8
Live Restore Enabled: falseWhat happened?
Similar to the Java testcontainers issue: testcontainers/testcontainers-java#4847, it could be useful to accept non-existent ~/.docker/config.json when finding docker auth configs.
Currently, when starting a container by building a Dockerfile using testcontainers.FromDockerfile, a ~/.docker/config.json is required, even if no credentials are needed to build the Dockerfile. This is an issue in environments that don't have a ~/.docker/config.json by default, such as on AWS CodeBuild, as it causes tests to fail. For example, an output of a failed test when running without a ~/.docker/config.json:
--- FAIL: TestHandler (10.81s)
test.go:60:
Error Trace: /codebuild/output/src3804529192/src/actions-runner/_work/orcabus/orcabus/lib/workload/stateless/stacks/fmannotator/internal/test/test.go:60
/codebuild/output/src3804529192/src/actions-runner/_work/orcabus/orcabus/lib/workload/stateless/stacks/fmannotator/internal/test/test.go:86
/codebuild/output/src3804529192/src/actions-runner/_work/orcabus/orcabus/lib/workload/stateless/stacks/fmannotator/handlers_test.go:70
Error: Received unexpected error:
create container: build options: auth configs from Dockerfile: open /root/.docker/config.json: no such file or directory
Test: TestHandler
FAIL
A workaround is to create an empty ~/.docker/config.json or set the DOCKER_CONFIG environment variable.
I think this could be fixed by changing how the errors are handled in getDockerAuthConfigs by returning an empty map[string]registry.AuthConfig instead of an error if ~/.docker/config.json could not be found.
Relevant log output
No response
Additional information
No response