fix: use regex to find container by name (#558)

hwwwi · mdelapenya · web-flow · commit b798926c8da8 · 2022-10-15T08:31:15.000+02:00
Co-authored-by: Manuel de la Peña &lt;mdelapenya@gmail.com&gt;
diff --git a/docker.go b/docker.go
@@ -1128,9 +1128,11 @@ func (p *DockerProvider) findContainerByName(ctx context.Context, name string) (
 	if name == "" {
 		return nil, nil
 	}
+
+	// Note that, 'name' filter will use regex to find the containers
 	filter := filters.NewArgs(filters.KeyValuePair{
 		Key:   "name",
-		Value: name,
+		Value: fmt.Sprintf("^%s$", name),
 	})
 	containers, err := p.client.ContainerList(ctx, types.ContainerListOptions{Filters: filter})
 	if err != nil {
diff --git a/docker_test.go b/docker_test.go
@@ -5,6 +5,8 @@ import (
 	"database/sql"
 	"errors"
 	"fmt"
+	// Import mysql into the scope of this package (required)
+	_ "github.com/go-sql-driver/mysql"
 	"io"
 	"io/ioutil"
 	"math/rand"
@@ -29,9 +31,6 @@ import (
 
 	"github.com/docker/docker/api/types/volume"
 
-	// Import mysql into the scope of this package (required)
-	_ "github.com/go-sql-driver/mysql"
-
 	"github.com/docker/docker/api/types"
 	"github.com/docker/docker/api/types/filters"
 	"github.com/docker/docker/client"
@@ -2496,3 +2495,40 @@ func randomString() string {
 	}
 	return b.String()
 }
+
+func TestDockerProviderFindContainerByName(t *testing.T) {
+	ctx := context.Background()
+	provider, err := NewDockerProvider(WithLogger(TestLogger(t)))
+	require.NoError(t, err)
+
+	c1, err := GenericContainer(ctx, GenericContainerRequest{
+		ProviderType: providerType,
+		ContainerRequest: ContainerRequest{
+			Name:       "test",
+			Image:      "nginx:1.17.6",
+			WaitingFor: wait.ForExposedPort(),
+		},
+		Started: true,
+	})
+	require.NoError(t, err)
+	c1Name, err := c1.Name(ctx)
+	require.NoError(t, err)
+	terminateContainerOnEnd(t, ctx, c1)
+
+	c2, err := GenericContainer(ctx, GenericContainerRequest{
+		ProviderType: providerType,
+		ContainerRequest: ContainerRequest{
+			Name:       "test2",
+			Image:      "nginx:1.17.6",
+			WaitingFor: wait.ForExposedPort(),
+		},
+		Started: true,
+	})
+	require.NoError(t, err)
+	terminateContainerOnEnd(t, ctx, c2)
+
+	c, err := provider.findContainerByName(ctx, "test")
+	assert.NoError(t, err)
+	require.NotNil(t, c)
+	assert.Contains(t, c.Names, c1Name)
+}
