You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 42ac7d2
Browse filesBrowse the repository at this point in the historyBrowse files
chore(wait)!: change url callback in wait.ForSQL to accept network.Port (#3650)
* chore!: wait.ForSQL: change url callback to accept network.Network
Commit 3e56fb9 updated this code to use
the moby modules, and changed signatures to accept a string for ports
("<port>[/<protocol>]"), handling conversion to strong types (`network.Port`)
internally.
In this case, however, the url callback function gets passed the host and
port that's already parsed internally, so downgrading the parsed `network.Port`
to a string means that a custom callback would have to parse the string again.
Change it to a strong-typed `network.Port`, which keeps all options open;
callbacks that want to use the port in its string-format can call `port.String()`,
but if only the port or proto is needed, they can use the `port.Port()`, `port.Proto()`
or other methods.
Signed-off-by: Sebastiaan van Stijn <[email protected]>
* docs: update ForSQL example to use network.Port callback
---------
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Co-authored-by: Manuel de la Peña <[email protected]>
0 commit comments