Skip to content

chore: Add nuget.config#1715

Merged
HofmeisterAn merged 1 commit into
testcontainers:developfrom
Rob-Hague:nugetconfig
Jun 28, 2026
Merged

chore: Add nuget.config#1715
HofmeisterAn merged 1 commit into
testcontainers:developfrom
Rob-Hague:nugetconfig

Conversation

@Rob-Hague

@Rob-Hague Rob-Hague commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes build warnings when multiple package sources are defined locally:

warning NU1507: There are 2 package sources defined in your configuration. When using central package management, please map your package sources with package source mapping (https://aka.ms/nuget-package-source-mapping) or specify a single package source.

Before: Build succeeded with 528 warning(s)
After: Build succeeded

Why is it important?

Release config builds with TreatWarningsAsErrors

Related issues

Summary by CodeRabbit

  • Chores
    • Updated package configuration to use the official NuGet package source only, helping keep dependency restores consistent.

Fixes build warnings when multiple package sources are defined locally:

warning NU1507: There are 2 package sources defined in your configuration. When using
central package management, please map your package sources with package source mapping
(https://aka.ms/nuget-package-source-mapping) or specify a single package source.

Before: Build succeeded with 528 warning(s)
After: Build succeeded
@Rob-Hague
Rob-Hague requested a review from HofmeisterAn as a code owner June 28, 2026 10:57
@netlify

netlify Bot commented Jun 28, 2026

Copy link
Copy Markdown

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 226ca77
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-dotnet/deploys/6a40fe04edc3e100080e4ac0
😎 Deploy Preview https://deploy-preview-1715--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Jun 28, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

A nuget.config file is added to the repository. It clears any pre-existing NuGet package sources and configures https://api.nuget.org/v3/index.json as the sole package source.

Changes

NuGet Configuration

Layer / File(s) Summary
NuGet package source configuration
nuget.config
Clears existing package sources and sets the official NuGet feed as the only source.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A rabbit hops in, config in paw,
One source to rule them all — no more, no flaw.
Clear the old feeds, start fresh and bright,
NuGet official, everything right.
🐇✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The PR includes the required what/why/related issues sections and clearly explains the warning fix and motivation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly matches the main change: adding a nuget.config file.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@HofmeisterAn HofmeisterAn added the chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups label Jun 28, 2026
@HofmeisterAn HofmeisterAn changed the title Add nuget.config chore: Add nuget.config Jun 28, 2026
@HofmeisterAn
HofmeisterAn merged commit eb54ebe into testcontainers:develop Jun 28, 2026
10 checks passed
@Rob-Hague
Rob-Hague deleted the nugetconfig branch June 28, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants