docs: Add missing TC languages and reorder docs navigation#1711
Conversation
Align header dropdown and landing page card-grid with the canonical language list: Java, Go, .NET, Node.js, Python, Rust, Ruby, PHP, Haskell, Clojure, Elixir, Scala, Native. - Add PHP, Clojure, Elixir, Scala, Native to header dropdown and card-grid - Fix ordering to match canonical list - Add missing logo SVGs (php, clojure, elixir, scala, c/native)
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughThe docs site is updated to expand language support visibility: the index page card grid gains entries for Rust, Ruby, PHP, Clojure, Elixir, Scala, and Native, while the header navigation template marks those same language submenu items as external links (new tab + icon) and updates Rust's documentation URL. ChangesLanguage Navigation Expansion
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c0406e89bd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/index.md`:
- Around line 55-76: Add `alt=""` attributes to all the `<img>` tags that
display language logos (Rust, Ruby, PHP, Haskell, Clojure, Elixir, Scala, and
Native). Since each card already contains visible text labels identifying the
language, these icons are decorative and should use empty alt text for
accessibility compliance and to prevent lint errors.
In `@docs/theme/partials/tc-header.html`:
- Around line 98-100: The Testcontainers Native (C/C++) entry that points to the
external GitHub URL is missing the "external": true property which other sibling
external language entries have. Add "external": true to the Testcontainers
Native language entry object to ensure it receives consistent new-tab and icon
behavior with the other external language links.
- Around line 40-42: The `.NET` child item object is missing the `url` property,
but the template renders child items as anchors using `href="{{ child.url }}"`,
which results in a broken link with an empty href. Either restore the `url`
property with an appropriate value for the `.NET` item (with label
"Testcontainers for .NET" and image "/language-logos/dotnet.svg"), or modify the
template logic to conditionally render the item as a non-link element when the
url is not present, ensuring the link contract is fulfilled or the item degrades
gracefully.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 2383ca6a-dc97-4ac2-a5f2-d4182c634065
⛔ Files ignored due to path filters (5)
docs/language-logos/c.svgis excluded by!**/*.svgdocs/language-logos/clojure.svgis excluded by!**/*.svgdocs/language-logos/elixir.svgis excluded by!**/*.svgdocs/language-logos/php.svgis excluded by!**/*.svgdocs/language-logos/scala.svgis excluded by!**/*.svg
📒 Files selected for processing (2)
docs/index.mddocs/theme/partials/tc-header.html
|
Fixed across all PRs: added |
|
Addressed review comments:
|
HofmeisterAn
changed the title
2 participants
Align header dropdown and landing page card-grid with the canonical language list: Java, Go, .NET, Node.js, Python, Rust, Ruby, PHP, Haskell, Clojure, Elixir, Scala, Native.
Summary by CodeRabbit
Documentation