Skip to content

chore: Rename runtime label and add buildkit and stale labels#1703

Merged
HofmeisterAn merged 1 commit into
developfrom
feature/github-labels-runtime-buildkit-stale
Jun 13, 2026
Merged

chore: Rename runtime label and add buildkit and stale labels#1703
HofmeisterAn merged 1 commit into
developfrom
feature/github-labels-runtime-buildkit-stale

Conversation

@HofmeisterAn

@HofmeisterAn HofmeisterAn commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

-

Why is it important?

-

Related issues

-

Summary by CodeRabbit

  • Chores
    • Updated repository labels: added “container runtime”, “buildkit”, and a “stale” label; removed “podman”.
  • Bug Fixes
    • Made command execution logging consistent so command output is logged reliably across runs.

@HofmeisterAn HofmeisterAn added the chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups label Jun 13, 2026
@netlify

netlify Bot commented Jun 13, 2026

Copy link
Copy Markdown

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 141c368
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-dotnet/deploys/6a2cfa37f97d530008618fc2
😎 Deploy Preview https://deploy-preview-1703--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

Updated GitHub issue/PR labels (removed "podman", added "container runtime", "buildkit", and "stale") and simplified Logging.ExecuteCommandInDockerContainer to always join the command into a single string and forward it to the core logging method.

Changes

Repository labels configuration

Layer / File(s) Summary
Updated GitHub issue and PR labels
.github/settings.yml
Removed the podman label and added container runtime and buildkit labels; added a stale label with color and description for inactive issues/PRs.

Logging wrapper change

Layer / File(s) Summary
Compute command line and call core logger
src/Testcontainers/Logging.cs
Logging.ExecuteCommandInDockerContainer now unconditionally constructs commandLine via string.Join(" ", command) and passes it to ExecuteCommandInDockerContainerCore, removing the prior IsEnabled(LogLevel.Information) check in the wrapper.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇 I stitched new tags and trimmed old thread,
I join the words a command once said,
Labels bright and logs in line,
A tidy repo — all's just fine.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is entirely incomplete with only placeholder dashes ('-') provided for all mandatory sections (What/Why) and recommended sections (Related issues/Testing). Complete all mandatory sections: explain what changes were made to the labels and why these changes are important. Add testing instructions and link any related issues.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately describes the main changes: renaming a runtime label (podman→container runtime) and adding buildkit and stale labels as documented in .github/settings.yml.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/github-labels-runtime-buildkit-stale

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/settings.yml:
- Around line 91-93: The renamed label "container runtime" currently drops the
old "podman" tag; restore compatibility by preserving "podman" as an alias or
secondary name for the label: update the label definition for "container
runtime" to include the legacy alias (e.g., add an aliases: ["podman"] entry or
equivalent in the label metadata) so existing issues/PRs, saved searches, and
automations still matching "podman" continue to work.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 3234a2f4-c951-4995-a2de-9b62409c4353

📥 Commits

Reviewing files that changed from the base of the PR and between b145ae1 and c0da98e.

📒 Files selected for processing (1)
  • .github/settings.yml

Comment thread .github/settings.yml
@HofmeisterAn
HofmeisterAn force-pushed the feature/github-labels-runtime-buildkit-stale branch from c0da98e to 141c368 Compare June 13, 2026 06:35

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/Testcontainers/Logging.cs (1)

206-210: ⚡ Quick win

Restore the IsEnabled check to avoid unnecessary allocations when logging is disabled.

The removal of the IsEnabled(LogLevel.Information) guard means string.Join(" ", command) now executes unconditionally, even when Information logging is disabled. This creates unnecessary string allocations in production scenarios where this log level is typically off. Since DockerContainerOperations.ExecAsync calls this wrapper for every container exec operation, the impact could be significant on hot paths.

Line 264 demonstrates the established pattern of guarding expensive operations with IsEnabled checks.

⚡ Proposed fix to restore the guard
 public static void ExecuteCommandInDockerContainer(this ILogger logger, string id, IEnumerable<string> command)
 {
+  if (!logger.IsEnabled(LogLevel.Information))
+  {
+    return;
+  }
+
   var commandLine = string.Join(" ", command);
   ExecuteCommandInDockerContainerCore(logger, commandLine, new TruncatedId(id));
 }
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/Testcontainers/Logging.cs` around lines 206 - 210, Restore the logging
guard in ExecuteCommandInDockerContainer to avoid allocating the joined command
string when Information logging is disabled: wrap the string.Join(" ", command)
and the call to ExecuteCommandInDockerContainerCore in an if
(logger.IsEnabled(LogLevel.Information)) { ... } block (using the same pattern
as seen at other sites), so only when logger.IsEnabled(LogLevel.Information) is
true you construct commandLine and call
ExecuteCommandInDockerContainerCore(logger, commandLine, new TruncatedId(id));
leave TruncatedId and ExecuteCommandInDockerContainerCore unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/Testcontainers/Logging.cs`:
- Around line 206-210: Restore the logging guard in
ExecuteCommandInDockerContainer to avoid allocating the joined command string
when Information logging is disabled: wrap the string.Join(" ", command) and the
call to ExecuteCommandInDockerContainerCore in an if
(logger.IsEnabled(LogLevel.Information)) { ... } block (using the same pattern
as seen at other sites), so only when logger.IsEnabled(LogLevel.Information) is
true you construct commandLine and call
ExecuteCommandInDockerContainerCore(logger, commandLine, new TruncatedId(id));
leave TruncatedId and ExecuteCommandInDockerContainerCore unchanged.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 850eaa3f-bbf9-46e6-bd9d-98b1ddd6209a

📥 Commits

Reviewing files that changed from the base of the PR and between c0da98e and 141c368.

📒 Files selected for processing (2)
  • .github/settings.yml
  • src/Testcontainers/Logging.cs
✅ Files skipped from review due to trivial changes (1)
  • .github/settings.yml

@HofmeisterAn HofmeisterAn changed the title chore: rename runtime label and add buildkit and stale labels chore: Rename runtime label and add buildkit and stale labels Jun 13, 2026
@HofmeisterAn
HofmeisterAn merged commit 638a926 into develop Jun 13, 2026
154 checks passed
@HofmeisterAn
HofmeisterAn deleted the feature/github-labels-runtime-buildkit-stale branch June 13, 2026 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant