Skip to content

feat: add doc for databend#75

Merged
mdelapenya merged 4 commits intotestcontainers:mainfrom
hantmac:feat/add-databend-module
Sep 25, 2024
Merged

feat: add doc for databend#75
mdelapenya merged 4 commits intotestcontainers:mainfrom
hantmac:feat/add-databend-module

Conversation

@hantmac
Copy link
Copy Markdown
Contributor

@hantmac hantmac commented Sep 21, 2024

No description provided.

maintainer: core
example: |
```java
var databendContainer = new DatabendContainer();
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eddumelendez do we need to explicitly pass the image in the examples?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdelapenya We need to pass the image name, I fixed it. Thanks!

@hantmac hantmac force-pushed the feat/add-databend-module branch from e513398 to c619498 Compare September 24, 2024 07:54
Copy link
Copy Markdown
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdelapenya mdelapenya self-assigned this Sep 25, 2024
@mdelapenya mdelapenya added the enhancement New feature or request label Sep 25, 2024
@mdelapenya mdelapenya merged commit ebf741b into testcontainers:main Sep 25, 2024
@mdelapenya
Copy link
Copy Markdown
Member

@hantmac I've added #76 fixing the white spaces (I tested it locally but never pushed the changes 🤦 )

We also updated the logo to comply with the design rules for the logos. PLMK what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants