Can these line be removed?
It seems redundant because we no longer depend on $LOAD_PATH.

• test-unit/test/run.rb

  Line 8 in e564ff0

  lib_dir = File.join(base_dir, "lib")

• test-unit/test/run.rb

  Line 11 in e564ff0

  $LOAD_PATH.unshift(lib_dir)

Hmm. Could you remove test/ changes from this PR?
We may want to use test/ for tests against installed test-unit.

Let's work on it as a separated PR.

Hmm. Could you remove test/ changes from this PR?
We may want to use test/ for tests against installed test-unit.

Yes, I'll remove test/ changes from this PR.

Oh, I didn't know that test/ could be used to test the installed gem.
Since test/ isn't included in the gem, require_relative wouldn't work in this context.
Thanks!

Let's work on it as a separated PR.

Sure!

The remaining require can be categorized as follows.
This list is based on the following command:

$ git grep --line-number --word-regexp require -- :^doc/ :^sample/ :^test/

External libraries

• Rakefile:16:require "erb"
• Rakefile:17:require "yaml"
• Rakefile:18:require "rubygems"
• Rakefile:19:require "rake/clean"
• Rakefile:20:require "yard"
• Rakefile:21:require "bundler/gem_helper"
• Rakefile:22:require "packnga"
• lib/test/unit/assertion-failed-error.rb:41: require "debug"
• lib/test/unit/assertions.rb:13: require 'power_assert'
• lib/test/unit/assertions.rb:2078: require "pp" unless defined?(PP)
• lib/test/unit/autorunner.rb:1:require "English"
• lib/test/unit/autorunner.rb:2:require "optparse"
• lib/test/unit/autorunner.rb:501: require "yaml"
• lib/test/unit/autorunner.rb:523: require "shellwords"
• lib/test/unit/collector/xml.rb:12:require 'rexml/document'
• lib/test/unit/collector/xml.rb:13:require 'rexml/streamlistener'
• lib/test/unit/data.rb:259: require 'csv'
• lib/test/unit/data.rb:305: require "csv"
• lib/test/unit/fault-location-detector.rb:5:require "English"
• lib/test/unit/priority.rb:20: require "fileutils"
• lib/test/unit/priority.rb:21: require "tmpdir"
• lib/test/unit/test-suite-runner.rb:9:require "etc"
• lib/test/unit/ui/console/testrunner.rb:10: require 'io/console'
• lib/test/unit/ui/console/testrunner.rb:13:require "pathname"
• lib/test/unit/collector/load.rb:1:require 'pathname'
• lib/test/unit/ui/xml/testrunner.rb:8:require 'erb'
• lib/test/unit/ui/xml/testrunner.rb:9:require 'time'
• lib/test/unit/util/backtracefilter.rb:2: require 'power_assert'
• lib/test/unit/util/output.rb:16: require 'stringio'

More advanced replacements

• bin/test-unit:3:require "test/unit"

Just comments

• lib/test/unit.rb:81: # "require 'test/unit'", plus his code to improve it even more by
• lib/test/unit.rb:180: # * require 'test/unit' in your test script.
• lib/test/unit.rb:192: # require 'test/unit'
• lib/test/unit.rb:213: # runner is automatically invoked for you if you require
• lib/test/unit.rb:218: # require 'test/unit'
• lib/test/unit.rb:234: # these up automatically when you require
• lib/test/unit.rb:238: # require 'test/unit'
• lib/test/unit.rb:239: # require 'test_myfirsttests'
• lib/test/unit.rb:240: # require 'test_moretestsbyme'
• lib/test/unit.rb:241: # require 'test_anothersetoftests'
• lib/test/unit/assertions.rb:1840: # require "objspace"
• lib/test/unit/assertions.rb:1851: # require "objspace"

No change needed

These are require calls, but $LOAD_PATH is unshifted just before, so they sould be fine.

• lib/test/unit/collector/dir.rb:91: @req.require(name)
• lib/test/unit/collector/dir.rb:93: require(name)
• lib/test/unit/collector/load.rb:118: require(expanded_path.to_s)

Test::Unit::UI::TestRunnerUtilities#start_command_line_test doesn't seem to be called, so it should also be fine.

• lib/test/unit/ui/testrunnerutilities.rb:35: require ARGV[0].gsub(/.+::/, '')