Make tests compatible with Node.js 12 and prerelease versions #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverwind
changed the title
semver.satisfies does not match a prerelease version against a non-prerelease one, e.g. 12.0.0-pre does not match >= 10. Use a regex match to workaround this fact.
In Node.js 12, the formatting of console arguments will change slightly. Previously, a string other than the first argument was formatted using single quotes if the first argument was non-string. Now, quotes are never added regardless of position of a string argument. To make test compatible in all Node.js versions, I work around by ensuring the first argument to console.log is a string which prevents the quotes from being added on older versions of Node.js. Ref: nodejs/node#23162
silverwind
force-pushed
the
node-12
branch
2 times, most recently
from
3468b04 to
00de155
Compare
silverwind
changed the title
Collaborator
|
Gee, that's great! I'll release it as soon as possible! |
Collaborator
|
What does console.log output look like then? |
Contributor
Author
Before 12: console.log(1, 'string')
// => 1 'string'
console.log('string', 'string')
// => string string After 12: console.log(1, 'string')
// => 1 string
console.log('string', 'string')
// => string string The type of the first argument no longer has significance on the quoting of further string arguments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two commits here to make the tests compatible with Node.js 12 as well as prerelease versions of Node.js.
First, the output semantics of
console.logfor cases of non-string first argument will change which breaks a few output expectations in the tests. I made the tests compatible with any Node.js version by ensuring that the first argument is a string, in which case the output will be the same in all versions.Additionally, the first commit makes the version check of
tools/colorless-console.jscompatible with prerelease versions of Node.js.Related: