Ensure parent directory exists when using --output on CLI#1530
Merged
fabiosantoscode merged 3 commits intoterser:masterfrom Oct 16, 2024
Merged
Ensure parent directory exists when using --output on CLI#1530fabiosantoscode merged 3 commits intoterser:masterfrom
fabiosantoscode merged 3 commits intoterser:masterfrom
Conversation
Collaborator
|
Hey there! Thanks for the PR You could add a test with --output on test/mocha/cli.js. I didn't find an existing one either! |
Contributor
Author
|
Finally got around to adding a test for this (sorry for the long wait). Ready for review. |
fabiosantoscode
approved these changes
Oct 16, 2024
Collaborator
fabiosantoscode
left a comment
fabiosantoscode
left a comment
There was a problem hiding this comment.
looks good, let me look at CI now
Collaborator
|
Great, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #962
Happy to add tests for this, but I didn't see any existing tests for the
--outputCLI option; am I missing them?