Repository navigation
Keep name of variable with anonymous function #191
Description
Bug report or Feature request?
Feature Request?
Version (complete output of terser -V)
terser 3.11.0
Complete CLI command or minify() options used
npm test
terser input
keep_var_fnames: {
mangle = {
keep_fnames: true,
}
input: {
function foo() {
const bar = function() {
return "foobar";
}
}
}
expect: {
function foo() {
const bar = function() {
return "foobar";
}
}
}
}
terser output or error
Running test [keep_var_fnames]
!!! failed
---INPUT---
{
function foo() {
const bar = function() {
return "foobar";
};
}
}
---OUTPUT---
function foo(){const o=function(){return"foobar"}}
---EXPECTED---
function foo(){const bar=function(){return"foobar"}}
Expected result
It would be mighty convenient if terser would recognize bar as function and not mangle the name when keep_fnames is set to true.
Activity
fabiosantoscode commentedon Dec 19, 2018
Nice issue.
The workaround is not to mangle. Not a good workaround.
I'll start working on it.
fabiosantoscode commentedon Dec 19, 2018
...But I have no idea how to do it. I'll work on it later.
fabiosantoscode commentedon Dec 19, 2018
PRs welcome!
jahed commentedon Mar 14, 2019
This also applies to arrow functions. Using the same example with
keep_fnames,becomes
fabiosantoscode commentedon Sep 29, 2019
It should be shipped soon. I don't know what took me so long, I love using anonymous arrow functions and giving them meaningful names.
thaoms commentedon Oct 2, 2019
Thank you for fixing this! This made all our React Components that are written as functional hooks
Anonymous.fabiosantoscode commentedon Oct 2, 2019
My use case was mostly for React too!
gdh1995 commentedon Oct 10, 2019
@fabiosantoscode The commit ff16f02 is not correct enough -
keep_fnamesmay be a regexp, but this commit treats a regexp astruewhen handing such functions.fix #191: some wrong logic about keep_fnames (#489)
close terser#191 by keeping variable names of anonymous functions and…