fix: made gradients work in sketch mode #2487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alixander
requested changes
Apr 10, 2025
Collaborator
alixander
left a comment
alixander
left a comment
There was a problem hiding this comment.
can you add a test to d2compiler?
Contributor
Author
Sure, I was waiting for your review on the implementation part. Will add it in the next commit. |
alixander
requested changes
Apr 12, 2025
alixander
approved these changes
Apr 14, 2025
Collaborator
alixander
left a comment
alixander
left a comment
There was a problem hiding this comment.
lgtm!
Lastly, could you add a line to next.md?
Contributor
Author
Sorry, I forgot to update it this time. Will update in next commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before d2 was throwing error while using gradient color values in sketch mode. The error was originating from the following line
d2/d2themes/sketch_overlay.go
Line 27 in 7563319
Basically, It can't parse a element fill value set as
url('#grad-<hash>')Now, as a part of the fix, we are checking fill value against a regex
^url\('#grad-[a-f0-9]{40}'\)$, it it matches, we set the luminance value tonormal, since we don't have access to actual gradient-colors anymore. Else we calculate the luminance value from the color value./fixes #2481