Skip to content

compiler: support center in d2-config #2360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alixander merged 2 commits into from
Feb 19, 2025
Merged

compiler: support center in d2-config #2360

alixander merged 2 commits into from
Feb 19, 2025

Conversation

@x-delfino
Copy link
Contributor

@x-delfino x-delfino commented Feb 18, 2025

This PR fixes support for center in d2-config variables. Looks like it was only partially implemented but should be supported per documentation.

Test file:

vars: {
  d2-config: {
    center: true
  }
}

x -> y

before change:

preserveAspectRatio="xMinYMin meet"

after change:

preserveAspectRatio="xMidYMid meet"

@x-delfino x-delfino mentioned this pull request Feb 18, 2025
Merged
alixander
alixander approved these changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, ty!

@alixander alixander merged commit 7741382 into terrastruct:master Feb 19, 2025
3 checks passed
@BrewTestBot BrewTestBot mentioned this pull request May 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alixander alixander alixander approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@x-delfino @alixander