d2target: add support for cross arrowhead #2190
Conversation
There was a problem hiding this comment.
💯 PR!
Do you mind adding a line to next.md?
I know you emulated what MermaidJS does with the cross, as depicted in the issue, but I wonder if that's ideal. Maybe Mermaid's implementation is not ideal, and a cross really should look like an x instead of this snowflake-look (*) with the endpoint extending all the way. I personally haven't used this endpoint before, so I don't know the answer. What do you think? Also cc @bo-ku-ra who originally filed the issue.
|
excellent! @MxHonesty @alixander the japanese are unique. most Japanese read the following. e.g. source-arrowhead: OK {
shape: circle
style.filled: false
}
target-arrowhead: NG {
shape: cross
}what is better for non-Japanese?
|
|
@bo-ku-ra Good insight, How did you get that screenshot from Mermaid? What's the code for it? |
|
yes, i agree. surprisingly, '✅' is the same as 'ｘ' in japan. e.x.
|
|
Hah, interesting. Well in any case, I think D2's E.g. the sketch version looks right 
but the non-sketch version looks like a snowflake 
@MxHonesty could you investigate that in this PR? I think the |
|
Sure, i will try doing it this way! |
|
hi @MxHonesty just wanted to check if you're still interested in pursuing this. No obligation of course, I can carry on what you have already if not. |
|
hi @alixander sorry for the inactivity. i had some busy weeks but was actually planning on picking up this work again this weekend if that's okay with you |
|
@MxHonesty No worries at all |
|
unfortunately canceled? |
|
I'll pick this back up before next release |
|
forgot? |
|
it's a lot of code changes required to hide that line that extends past the cross intersection unfortunately. We'll release v1 of it as this type of cross, and if there's sufficient demand, update it |
3 participants
Add support for cross arrowhead in d2target (and d2sketch).
closes #2028
Why i chose polygon
In order to keep the look of the suggestion i went with a rotated polygon instead of simple crossing lines. Would appreciate feedback on this.
End-to-End Tests:
CrossArrowheadine2etests/stable_test.go.CrossArrowheadine2etests/testdata/files/cross_arrowhead.d2.CrossArrowheadtests ine2etests/testdata/txtar/sketch-cross-arrowhead/dagre/board.exp.jsonande2etests/testdata/txtar/sketch-cross-arrowhead/elk/board.exp.json.CrossArrowheadin thee2etests/txtar.txtfile.Images