support latin-1 and geometric shape unicode chars #2100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alixander
force-pushed
the
extended-ascii
branch
from
a053840 to
0d13bb9
Compare
alixander
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1811
Latin-1 and geometric shape unicode chars supported by the loaded font are measured correctly now. In the below example, the unicode for the bullseye is not supported for Source Sans Pro, so is still measured incorrectly. However, the coverage is much better
Note that it's possible to extend this further to all unicode chars, but it reduces performance by a lot (runtime of all tests went from 46s to 112s) for very little gain.