Skip to content

fix elk layout with outside positioned labels/icons #1776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gavin-ts merged 14 commits into from
Dec 13, 2023
Merged

fix elk layout with outside positioned labels/icons #1776

gavin-ts merged 14 commits into from
Dec 13, 2023

Conversation

@gavin-ts
Copy link
Contributor

@gavin-ts gavin-ts commented Dec 12, 2023 •
edited
Loading

Summary

Update elk layout positioning with icons and labels in outside positions.

Details

  • see allow icon for sql_table, class, code/md #1774 (comment)
  • updates elk layout adjustments for outside positioned icons/labels
  • outside labels/icons no longer merge with container padding since they may introduce overlaps with inside container labels/icons
  • will trace edge to shape's outside icon the same way it will trace to a shape's outside label

before/after

Screenshot 2023-12-12 at 4 44 43 PM Screenshot 2023-12-12 at 4 42 42 PM

tracing to outside icon

trace.to.outside.iconst.mp4

fixes odd spacing with multiple/3d

odd.multiple.spacing.mp4

e2ereport

_Users_gavinnishizawa_github_repos_d2_e2etests_out_e2e_report html

@gavin-ts gavin-ts force-pushed the layout-with-outside-icons branch from 162cad3 to b299389 Compare December 13, 2023 00:32
@gavin-ts gavin-ts force-pushed the layout-with-outside-icons branch from b299389 to 94055a0 Compare December 13, 2023 00:48
@gavin-ts gavin-ts changed the title fix layout with outside positioned icons fix elk layout with outside positioned labels/icons Dec 13, 2023
@gavin-ts gavin-ts requested a review from alixander December 13, 2023 01:40
@gavin-ts gavin-ts marked this pull request as ready for review December 13, 2023 01:40
@alixander alixander mentioned this pull request Dec 13, 2023
Merged
alixander
alixander approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gavin-ts gavin-ts merged commit 2829a6a into terrastruct:master Dec 13, 2023
@BrewTestBot BrewTestBot mentioned this pull request Dec 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alixander alixander alixander approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gavin-ts @alixander