Skip to content

Conversation

@gavin-ts
Copy link
Contributor

@gavin-ts gavin-ts commented Nov 14, 2023

Summary

Fixes a panic with an unrouted edge to a grid cell that is a container.

Details

  • fixes Error with connection to grid cell container #1719
  • for grid cells that are containers, external edge object references(pointers) were not updated after layout
  • this caused grid layout to incorrectly skip routing for the cell-cell edge, leading to an empty route and a panic during rendering
  • fixed by updating the object references used for grid cell containers after running layout
  • this wouldn't occur with dagre/elk but would occur with TALA or other plugins that don't return the exact same *d2graph.Object from Layout

@gavin-ts gavin-ts requested a review from alixander November 14, 2023 05:49
@gavin-ts gavin-ts marked this pull request as ready for review November 14, 2023 05:49
@gavin-ts gavin-ts enabled auto-merge November 14, 2023 05:53
@gavin-ts gavin-ts force-pushed the fix-external-grid-cell-container-edge branch from c659455 to 01248d4 Compare November 14, 2023 05:55
@gavin-ts gavin-ts merged commit 6324d67 into terrastruct:master Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error with connection to grid cell container

2 participants