Skip to content

Fix grid rows gap bug #1646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gavin-ts merged 5 commits into from
Oct 6, 2023
Merged

Fix grid rows gap bug #1646

gavin-ts merged 5 commits into from
Oct 6, 2023

Conversation

@gavin-ts
Copy link
Contributor

@gavin-ts gavin-ts commented Oct 6, 2023

Summary

Fixes a bug calculating the grid height with only grid-rows and different horizontal-gap and vertical-gap.

Details

before/after

Screenshot 2023-10-05 at 6 49 18 PM

@gavin-ts gavin-ts requested a review from alixander October 6, 2023 01:55
@gavin-ts gavin-ts enabled auto-merge October 6, 2023 01:57
@gavin-ts gavin-ts merged commit db126ab into terrastruct:master Oct 6, 2023
@BrewTestBot BrewTestBot mentioned this pull request Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alixander alixander alixander approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix grid-rows with horizontal-gap > vertical-gap

2 participants

@gavin-ts @alixander