Skip to content

Markdown style regression on v.0.2.1? #1805

@villesalmela

Description

@villesalmela

In short

I think v0.2.1 broke something on markdown styling, fill and stroke on markdown text no longer work as expected. Doesn't work on latest version either.
I reviewed changelog for v0.2.1, and don't think that this is an intended change.

I'm new to D2, so could be just a misundestanding on my part, but could you please check?

Details

PR #460 introduced style.fill and style.stroke for Markdown text in v.0.1.2.
E2E test added in the same PR: d28aed6

d2/e2etests/stable_test.go

Lines 1491 to 1515 in d28aed6

container.md: |md
# a header
a line of text and an
{
indented: "block",
of: "json",
}
walk into a bar.
| {
style.stroke: darkorange
}
container -> no container
no container: |md
they did it in style
|
no container.style: {
stroke: red
fill: "#CEEDEE"
}

Using the above D2 code from the test, I am unable to get expected results on v0.6.3..v0.2.1.
Using v0.2.0 I do get the expected result.

Demonstration

Using the same test input (above) and ELK layout, results by version:
v0.1.2 (feature introduced)
test_v0 1 2

v0.2.0 (feature last observed working)
test_v0 2 0

v0.2.1 (feature stops working)
test_v0 2 1

v0.6.3 (latest version)
test_v0 6 3

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions