hotfix(main/termux-tools): fixed motd logo wrap#11294
hotfix(main/termux-tools): fixed motd logo wrap#11294landfillbaby merged 2 commits intotermux:masterfrom TermuxMonet:master
Conversation
TermuxMonet
requested review from
2096779623,
Grimler91,
finagolfin and
landfillbaby
as code owners
|
Please anyone merge this asap, there's fixes for bugs on two merged PRs related to termux tools |
Fixed motd logo being destroyed by text wrap when zoom-in.
|
How does adding a dot prevent word wrap? Whether there is a dot or space in a cell, doesn't affect other cells. Motd will get broken on small devices or people who zoom to around 50 char width. And why are pull requests being submitted (and merged) without testing, specially one for a fix? Also @landfillbaby, I know you have been away, but please follow (the new) commit messages format. Thanks :)
|
The wrap can't be avoided, that's impossible with this hotfix, it doesn't get destroyed. that's what was reported on this comment |
- The logo added in new dynamic motd would break due to word wrap if terminal columns were less than max line length. This fixes the issue by not drawing a logo if terminal columns are too few at draw time. Note that logo will still break if terminal size is changed after drawing. - Use TERMUX_APP_PACKAGE_MANAGER instead of TERMUX_MAIN_PACKAGE_FORMAT - Add donate link instead of gitter which should already exist in community link, including matrix rooms link. Related pull requests termux/termux-packages#11250 and termux/termux-packages#11294
- The logo added in new dynamic motd would break due to word wrap if terminal columns were less than max line length. This fixes the issue by not drawing a logo if terminal columns are too few at draw time. Note that logo will still break if terminal size is changed after drawing. - Use TERMUX_APP_PACKAGE_MANAGER instead of TERMUX_MAIN_PACKAGE_FORMAT - Add donate link instead of gitter which should already exist in community link, including matrix rooms link. Related pull requests termux/termux-packages#11250 and termux/termux-packages#11294
3 participants
Fixed motd logo being destroyed by text wrap when zoom-in.
Solution explanation:
#11250 (comment)
Bug report:
#11250 (comment)
Also fixed regular motd display when dynamic motd is missing (bug found in 9678f88)