Fixed: Fix exception in ResultReturner while setting result for a non-ordered broadcast

agnostic-apollo · agnostic-apollo · commit e994de52d7d2 · 2024-03-20T04:33:40.000+05:00
```
java.lang.RuntimeException: BroadcastReceiver trying to return result during a non-ordered broadcast
    at android.content.BroadcastReceiver$PendingResult.checkSynchronousHint(BroadcastReceiver.java:351)
    at android.content.BroadcastReceiver$PendingResult.setResultCode(BroadcastReceiver.java:154)
    at com.termux.api.util.ResultReturner.lambda$returnData$0(ResultReturner.java:196)
    at com.termux.api.util.ResultReturner$$ExternalSyntheticLambda0.run(Unknown Source:8)
    at java.lang.Thread.run(Thread.java:1012)
```
diff --git a/app/src/main/java/com/termux/api/util/ResultReturner.java b/app/src/main/java/com/termux/api/util/ResultReturner.java
@@ -144,9 +144,9 @@ public static void copyIntentExtras(Intent origIntent, Intent newIntent) {
      * Run in a separate thread, unless the context is an IntentService.
      */
     public static void returnData(Object context, final Intent intent, final ResultWriter resultWriter) {
-        final PendingResult asyncResult = (context instanceof BroadcastReceiver) ? ((BroadcastReceiver) context)
-                .goAsync() : null;
+        final BroadcastReceiver receiver = (BroadcastReceiver) ((context instanceof BroadcastReceiver) ? context : null);
         final Activity activity = (Activity) ((context instanceof Activity) ? context : null);
+        final PendingResult asyncResult = receiver != null ? receiver.goAsync() : null;
 
         final Runnable runnable = () -> {
             PrintWriter writer = null;
@@ -192,7 +192,7 @@ public static void returnData(Object context, final Intent intent, final ResultW
                     pfds[0].close();
                 }
 
-                if (asyncResult != null) {
+                if (asyncResult != null && receiver.isOrderedBroadcast()) {
                     asyncResult.setResultCode(0);
                 } else if (activity != null) {
                     activity.setResult(0);
@@ -204,7 +204,7 @@ public static void returnData(Object context, final Intent intent, final ResultW
                 TermuxPluginUtils.sendPluginCommandErrorNotification(ResultReturner.context, LOG_TAG,
                         TermuxConstants.TERMUX_API_APP_NAME + " Error", message, t);
 
-                if (asyncResult != null) {
+                if (asyncResult != null && receiver != null && receiver.isOrderedBroadcast()) {
                     asyncResult.setResultCode(1);
                 } else if (activity != null) {
                     activity.setResult(1);
