Conversation
20596b6 to
d522206
Compare
|
The force push was amending the license field. Angband is dual-licensed with the GPL 2.0 and Angband licenses, but games that were forked from earlier versions are just the Angband license which states:
(And that seemed to break the tests, because it no longer recognizes that as a valid license) Does this mean that this roguelike is incompatible with being packaged? |
|
Hi, nice!
It means that we cannot host it on bintray in open-source accounts (i.e. bintray.com/grimler and bintray.com/xeffyr), it would be fine to have it in the main termux-packages repository (bintray.com/termux) though, "custom" licenses are acceptable there since they sponsor us, so you can open a PR towards the main repository and specify |
|
Oh! Thanks for the heads up! I might just do that~ ^^ The Angband license was made before GPL existed, and while it was pretty explicitly noncommercial, it still required a couple tweaks before it was entirely compatible with free software licenses that came later. (Someone even ended up hunting down all the previous authors to make sure they were okay with the re-license to GPL 2, which was pretty wild) But yeah, I can definitely extract that license into that path. |
|
Alright! So the package now has a custom license set, and installs a How does this look? ^^ |
Oh wait... By "main repository", do you mean the non-game termux-packages? If so, I read that very differently until a few seconds ago. |
Yeah, only packages with one of these licenses can be uploaded to bintray.com/grimler/game-packages-24: We don't have the same restriction in github.com/termux/termux-packages though, so could you open a PR against the main repo instead? |
|
Alright! Done! (Which means this PR probably isn't really needed anymore.) Thank you for your patience with me though! |
I've managed to get several roguelikes to build and run on Termux, and after writing a big 'ol post about doing that, and after helping quite a few people to get them up and running, I figured that I might as well contribute to the repos itself!
This is the first of several packages I plan on making, though I wanted to make sure everything is on the up and up contribution-wise before I build the scripts for the other ones. ^^
The game itself is FrogComposband, which is one of the most popular bands out there currently, which features an overworld, a lot of quests, and is one of the most played on angband.live currently.