Allow empty configuration values to be supplied from environment#89032
Allow empty configuration values to be supplied from environment#89032copybara-service[bot] merged 1 commit intotensorflow:masterfrom
Conversation
For example it may be desirable for `CC_OPT_FLAGS` to be empty.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hi @elfprince13, Can you please sign the CLA? Many thanks! |
google-ml-butler
bot
added
kokoro:force-run
github-project-automation
bot
moved this from Assigned Reviewer
to Approved by Reviewer
in PR Queue
Hi, I actually already signed it and the CI bot just didn't re-run afterward =) |
|
So the bot requires someone (contributor or reviewer) to retrigger a scan. From the check page, there's a link for that, when the CLA check fails. |
|
@mihaimaruseac anything remaining before it can be merged? |
github-project-automation
bot
moved this from Approved by Reviewer
to Closed/Rejected
in PR Queue
google-ml-butler
bot
removed
awaiting review
|
Sorry, I was away while you sent the last message, but the delay here was caused by the need to have this PR imported into the internal systems, more CI to run on the result of the import and a different set of approvers. The process is documented somewhat in CONTRIBUTING.md |
5 participants
For example it may be desirable for
CC_OPT_FLAGSto be empty.