Skip to content

[TF:TRT] Move definition of TrtPrecisionMode and ProfileStrategy to a separate header - #52595

Merged
copybara-service[bot] merged 1 commit into
tensorflow:masterfrom
tfeher:trt_cpp_converter_headers
Nov 17, 2021
Merged

copybara-service[bot] merged 1 commit into
tensorflow:masterfrom
tfeher:trt_cpp_converter_headers

Conversation

@tfeher

@tfeher tfeher commented Oct 20, 2021

Copy link
Copy Markdown
Contributor

The TF-TRT cpp converter needs to include the definition of TrtPrecisionMode and ProfileStrategy. Previously, these were defined in convert/utils.h which depends on third_party/tensorrt/NvInfer.h. This third party header is not installed along with the rest of the header files. This PR moves the definitions to a separate header file. This way trt_converter_api.h is not dependent on NvInfer.h anymore.

Tracker: #45481

Tagging @bixia1 for review.

@google-ml-butler google-ml-butler Bot added the size:L CL Change Size: Large label Oct 20, 2021
@google-cla google-cla Bot added the cla: yes label Oct 20, 2021
@google-ml-butler google-ml-butler Bot added the awaiting review Pull request awaiting review label Oct 20, 2021
@bixia1
bixia1 self-requested a review October 20, 2021 16:30
@bixia1 bixia1 added the comp:gpu:tensorrt Issues specific to TensorRT label Oct 20, 2021
@gbaned gbaned self-assigned this Oct 21, 2021
@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label Oct 29, 2021
@tfeher
tfeher force-pushed the trt_cpp_converter_headers branch from f206d61 to 8417861 Compare November 15, 2021 23:06
@tfeher
tfeher force-pushed the trt_cpp_converter_headers branch from 8417861 to 8be5f68 Compare November 16, 2021 00:22
@tfeher

tfeher commented Nov 16, 2021

Copy link
Copy Markdown
Contributor Author

Resolved conflicts.

@gbaned
gbaned requested a review from bixia1 November 16, 2021 05:26
@google-ml-butler google-ml-butler Bot added the awaiting review Pull request awaiting review label Nov 16, 2021
@google-ml-butler google-ml-butler Bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Nov 16, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Nov 16, 2021
@copybara-service
copybara-service Bot merged commit 137ec39 into tensorflow:master Nov 17, 2021
@google-ml-butler google-ml-butler Bot removed awaiting review Pull request awaiting review ready to pull PR ready for merge process labels Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes comp:gpu:tensorrt Issues specific to TensorRT size:L CL Change Size: Large

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants